All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, NeilBrown <neilb@suse.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	kinglongmee@gmail.com
Subject: Re: [PATCH 4/6 v9] fs: New helper legitimize_mntget() for getting a legitimize mnt
Date: Fri, 28 Aug 2015 07:02:39 +0800	[thread overview]
Message-ID: <55DF970F.6080308@gmail.com> (raw)
In-Reply-To: <20150819050245.GC18890@ZenIV.linux.org.uk>

On 8/19/2015 13:02, Al Viro wrote:
> On Wed, Aug 19, 2015 at 02:56:50PM +1000, NeilBrown wrote:
>> If not, we need to clean up and try again.
>> To do this we need to check MNT_SYNC_UMOUNT.
>> If that is clear it is safe and best to call mntput() on the mnt.
>> If it is set, then we just do the mnt_add_count(mnt, -1) and give up
>> completely.
> 
> It's more subtle, actually.  See my reply upthread for details, but
> basically we rely on rcu_read_lock() held since before that MNT_SYNC_UMOUNT
> had been set, making synchronize_rcu() in namespace_unlock() a guaranteed
> delay of the final mntput until after we have returned.
> 

Thanks for the comments.
I will update this patch according to Neil's comments and __legitimize_mnt.

thanks,
Kinglong Mee

WARNING: multiple messages have this Message-ID (diff)
From: Kinglong Mee <kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	NeilBrown <neilb-IBi9RG/b67k@public.gmane.org>
Cc: "J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
	"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Trond Myklebust
	<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
	kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 4/6 v9] fs: New helper legitimize_mntget() for getting a legitimize mnt
Date: Fri, 28 Aug 2015 07:02:39 +0800	[thread overview]
Message-ID: <55DF970F.6080308@gmail.com> (raw)
In-Reply-To: <20150819050245.GC18890-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>

On 8/19/2015 13:02, Al Viro wrote:
> On Wed, Aug 19, 2015 at 02:56:50PM +1000, NeilBrown wrote:
>> If not, we need to clean up and try again.
>> To do this we need to check MNT_SYNC_UMOUNT.
>> If that is clear it is safe and best to call mntput() on the mnt.
>> If it is set, then we just do the mnt_add_count(mnt, -1) and give up
>> completely.
> 
> It's more subtle, actually.  See my reply upthread for details, but
> basically we rely on rcu_read_lock() held since before that MNT_SYNC_UMOUNT
> had been set, making synchronize_rcu() in namespace_unlock() a guaranteed
> delay of the final mntput until after we have returned.
> 

Thanks for the comments.
I will update this patch according to Neil's comments and __legitimize_mnt.

thanks,
Kinglong Mee
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-08-27 23:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  7:17 [PATCH 0/6 v9] NFSD: Pin to vfsmount for nfsd exports cache Kinglong Mee
2015-08-18  7:17 ` Kinglong Mee
2015-08-18  7:18 ` [PATCH 1/6 v9] fs-pin: allow pin_remove() to be called other than from->kill() Kinglong Mee
2015-08-18  7:18   ` Kinglong Mee
2015-08-18  7:19 ` [PATCH 2/6] fs_pin: Export functions for specific filesystem Kinglong Mee
2015-08-18  7:19   ` Kinglong Mee
2015-08-18  7:20 ` [PATCH 3/6 v9] path: New helpers path_get_pin/path_put_unpin for path pin Kinglong Mee
2015-08-18  7:20   ` Kinglong Mee
2015-08-18  7:21 ` [PATCH 4/6 v9] fs: New helper legitimize_mntget() for getting a legitimize mnt Kinglong Mee
2015-08-18  7:21   ` Kinglong Mee
2015-08-19  4:56   ` NeilBrown
2015-08-19  4:56     ` NeilBrown
2015-08-19  5:02     ` Al Viro
2015-08-27 23:02       ` Kinglong Mee [this message]
2015-08-27 23:02         ` Kinglong Mee
2015-08-18  7:22 ` [PATCH 5/6 v9] sunrpc: New helper cache_delete_entry for deleting cache_head directly Kinglong Mee
2015-08-18  7:22   ` Kinglong Mee
2015-08-18  7:23 ` [PATCH 6/6 v9] nfsd: Allows user un-mounting filesystem where nfsd exports base on Kinglong Mee
2015-08-18  7:23   ` Kinglong Mee
2015-08-19  3:54   ` NeilBrown
2015-08-19  3:54     ` NeilBrown
2015-08-19  4:50   ` Al Viro
2015-08-19  4:50     ` Al Viro
2015-08-27 23:15     ` Kinglong Mee
2015-08-27 23:15       ` Kinglong Mee
2015-08-18  7:24 ` [PATCH 2/6 v9] fs_pin: Export functions for specific filesystem Kinglong Mee
2015-08-18  7:24   ` Kinglong Mee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DF970F.6080308@gmail.com \
    --to=kinglongmee@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.