From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: FIB tracepoints
Date: Thu, 27 Aug 2015 22:07:30 -0700 [thread overview]
Message-ID: <55DFEC92.8050700@cumulusnetworks.com> (raw)
In-Reply-To: <20150827.220538.2154843333132928646.davem@davemloft.net>
On 8/27/15 10:05 PM, David Miller wrote:
> From: David Ahern <dsa@cumulusnetworks.com>
> Date: Thu, 27 Aug 2015 21:59:32 -0700
>
>> + __array( __u8, src, 4 )
>> + __array( __u8, dst, 4 )
> ...
>> + __array( __u8, src, 4 )
>
> Maybe there is something I don't understand about tracing, but why not
> use __u32? If endianness types are the issue, just force cast it as
> needed.
>
> Using a memcpy() on a 4-byte array is kinda excessive.
>
Silly trick need to use %pI4. ie., printing the addresses as strings vs.
hex.
next prev parent reply other threads:[~2015-08-28 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 4:59 [PATCH net-next] net: FIB tracepoints David Ahern
2015-08-28 5:05 ` David Miller
2015-08-28 5:07 ` David Ahern [this message]
2015-08-28 5:12 ` David Ahern
2015-08-28 5:17 ` David Miller
2015-08-28 5:32 ` David Ahern
2015-08-28 5:48 ` David Miller
2015-08-28 5:16 ` David Miller
2015-08-28 5:27 ` David Ahern
2015-08-28 5:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DFEC92.8050700@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.