All of lore.kernel.org
 help / color / mirror / Atom feed
From: Weilong Chen <chenweilong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <eric.dumazet@gmail.com>, <edumazet@google.com>,
	<alexander.h.duyck@redhat.com>, <willemb@google.com>,
	<hannes@stressinduktion.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order
Date: Fri, 28 Aug 2015 13:34:13 +0800	[thread overview]
Message-ID: <55DFF2D5.7080102@huawei.com> (raw)
In-Reply-To: <20150827.212639.868701692675372953.davem@davemloft.net>

> From: Weilong Chen <chenweilong@huawei.com>
> Date: Fri, 28 Aug 2015 11:35:40 +0800
>
>> In my test, @to has a fraglist, but skb_tailroom(to) is not 0!
>> The test is about tipc, the function tipc_buf_append will merge 3 skbs
>> to one:
>> packet 1: len = 1420 skb_tailroom = 190
>> packet 2: len = 1420
>> 	packet 2 will be add to 1' fraglist, but not update skb_tailroom
>
> This operation is illegal.
>
> Once there are frags, tailroom is not permitted.
>
> .
>

Agree

Thanks

  reply	other threads:[~2015-08-28  5:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  0:56 [PATCH net-next] net: Check frag_lists first to prevent data out of order chenweilong
2015-08-27  2:12 ` Eric Dumazet
2015-08-27  2:23   ` Eric Dumazet
2015-08-28  3:35     ` Weilong Chen
2015-08-28  4:26       ` David Miller
2015-08-28  5:34         ` Weilong Chen [this message]
2015-08-28  4:37       ` Eric Dumazet
2015-08-28  5:33         ` Weilong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DFF2D5.7080102@huawei.com \
    --to=chenweilong@huawei.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.