From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] drm: msm: dsi: Don't attempt changing voltage of switches Date: Fri, 28 Aug 2015 15:57:09 +0530 Message-ID: <55E0377D.2050603@codeaurora.org> References: <1439919272-19793-1-git-send-email-bjorn.andersson@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1AA96ED47 for ; Fri, 28 Aug 2015 03:27:16 -0700 (PDT) In-Reply-To: <1439919272-19793-1-git-send-email-bjorn.andersson@sonymobile.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bjorn Andersson , Rob Clark , Hai Li Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAwOC8xOC8yMDE1IDExOjA0IFBNLCBCam9ybiBBbmRlcnNzb24gd3JvdGU6Cj4gSW4g c29tZSBjb25maWd1cmF0aW9ucyB0aGUgc3VwcGxpZXMgYXJlIHZvbHRhZ2Ugc3dpdGNoZXMgYW5k IG5vdCBMRE9zLAo+IG1ha2luZyB0aGUgc2V0IHZvbHRhZ2UgY2FsbCB0byBmYWlsLiBDaGVjayB3 aXRoIHRoZSByZWd1bGF0b3IgZnJhbWV3b3JrCj4gaWYgdGhlIHN1cHBseSBjYW4gY2hhbmdlIHZv bHRhZ2UgYmVmb3JlIGF0dGVtcHRpbmcuCj4KPiBTaWduZWQtb2ZmLWJ5OiBCam9ybiBBbmRlcnNz b24gPGJqb3JuLmFuZGVyc3NvbkBzb255bW9iaWxlLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9tc20vZHNpL2RzaV9ob3N0LmMgICAgfCAyICstCj4gICBkcml2ZXJzL2dwdS9kcm0vbXNt L2RzaS9waHkvZHNpX3BoeS5jIHwgMiArLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21z bS9kc2kvZHNpX2hvc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMKPiBp bmRleCA4YzE2ZDZhM2NhNzguLmVjZTNkZTZhODE1NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kv ZHNpX2hvc3QuYwo+IEBAIC0yNzgsNyArMjc4LDcgQEAgc3RhdGljIGludCBkc2lfcmVndWxhdG9y X2luaXQoc3RydWN0IG1zbV9kc2lfaG9zdCAqbXNtX2hvc3QpCj4gICAJfQo+Cj4gICAJZm9yIChp ID0gMDsgaSA8IG51bTsgaSsrKSB7Cj4gLQkJaWYgKChyZWdzW2ldLm1pbl92b2x0YWdlID49IDAp ICYmIChyZWdzW2ldLm1heF92b2x0YWdlID49IDApKSB7Cj4gKwkJaWYgKHJlZ3VsYXRvcl9jYW5f Y2hhbmdlX3ZvbHRhZ2Uoc1tpXS5jb25zdW1lcikpIHsKPiAgIAkJCXJldCA9IHJlZ3VsYXRvcl9z ZXRfdm9sdGFnZShzW2ldLmNvbnN1bWVyLAo+ICAgCQkJCXJlZ3NbaV0ubWluX3ZvbHRhZ2UsIHJl Z3NbaV0ubWF4X3ZvbHRhZ2UpOwo+ICAgCQkJaWYgKHJldCA8IDApIHsKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGh5L2RzaV9waHkuYyBiL2RyaXZlcnMvZ3B1L2RybS9t c20vZHNpL3BoeS9kc2lfcGh5LmMKPiBpbmRleCA0MDFmZjU4ZDY4OTMuLmYxZjk1NWY1NzFmYSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9waHkvZHNpX3BoeS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGh5L2RzaV9waHkuYwo+IEBAIC0xNzgsNyArMTc4 LDcgQEAgc3RhdGljIGludCBkc2lfcGh5X3JlZ3VsYXRvcl9pbml0KHN0cnVjdCBtc21fZHNpX3Bo eSAqcGh5KQo+ICAgCX0KPgo+ICAgCWZvciAoaSA9IDA7IGkgPCBudW07IGkrKykgewo+IC0JCWlm ICgocmVnc1tpXS5taW5fdm9sdGFnZSA+PSAwKSAmJiAocmVnc1tpXS5tYXhfdm9sdGFnZSA+PSAw KSkgewo+ICsJCWlmIChyZWd1bGF0b3JfY2FuX2NoYW5nZV92b2x0YWdlKHNbaV0uY29uc3VtZXIp KSB7Cj4gICAJCQlyZXQgPSByZWd1bGF0b3Jfc2V0X3ZvbHRhZ2Uoc1tpXS5jb25zdW1lciwKPiAg IAkJCQlyZWdzW2ldLm1pbl92b2x0YWdlLCByZWdzW2ldLm1heF92b2x0YWdlKTsKPiAgIAkJCWlm IChyZXQgPCAwKSB7Cj4KCkxvb2tzIGdvb2QgdG8gbWUuCgpSZXZpZXdlZC1ieTogQXJjaGl0IFRh bmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4KCkFyY2hpdAoKLS0gClF1YWxjb21tIElubm92 YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVtLAphIExp bnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbbH1K1R (ORCPT ); Fri, 28 Aug 2015 06:27:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48918 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbbH1K1P (ORCPT ); Fri, 28 Aug 2015 06:27:15 -0400 Message-ID: <55E0377D.2050603@codeaurora.org> Date: Fri, 28 Aug 2015 15:57:09 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Bjorn Andersson , Rob Clark , Hai Li CC: Stephane Viau , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: msm: dsi: Don't attempt changing voltage of switches References: <1439919272-19793-1-git-send-email-bjorn.andersson@sonymobile.com> In-Reply-To: <1439919272-19793-1-git-send-email-bjorn.andersson@sonymobile.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/18/2015 11:04 PM, Bjorn Andersson wrote: > In some configurations the supplies are voltage switches and not LDOs, > making the set voltage call to fail. Check with the regulator framework > if the supply can change voltage before attempting. > > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 8c16d6a3ca78..ece3de6a8157 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -278,7 +278,7 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host) > } > > for (i = 0; i < num; i++) { > - if ((regs[i].min_voltage >= 0) && (regs[i].max_voltage >= 0)) { > + if (regulator_can_change_voltage(s[i].consumer)) { > ret = regulator_set_voltage(s[i].consumer, > regs[i].min_voltage, regs[i].max_voltage); > if (ret < 0) { > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index 401ff58d6893..f1f955f571fa 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -178,7 +178,7 @@ static int dsi_phy_regulator_init(struct msm_dsi_phy *phy) > } > > for (i = 0; i < num; i++) { > - if ((regs[i].min_voltage >= 0) && (regs[i].max_voltage >= 0)) { > + if (regulator_can_change_voltage(s[i].consumer)) { > ret = regulator_set_voltage(s[i].consumer, > regs[i].min_voltage, regs[i].max_voltage); > if (ret < 0) { > Looks good to me. Reviewed-by: Archit Taneja Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project