From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC 04/10] ravb: Add support for r8a7795 SoC
Date: Fri, 28 Aug 2015 10:30:16 +0000 [thread overview]
Message-ID: <55E03838.3080604@cogentembedded.com> (raw)
In-Reply-To: <1440667450-3513-5-git-send-email-horms+renesas@verge.net.au>
Hello.
On 8/28/2015 5:13 AM, Simon Horman wrote:
>>>> @@ -1688,6 +1712,16 @@ static int ravb_probe(struct platform_device *pdev)
>>>> priv->avb_link_active_low >>>> of_property_read_bool(np, "renesas,ether-link-active-low");
>>>>
>>>> + if (of_device_is_compatible(np,
>>>> + "renesas,etheravb-r8a7795")) {
>>>
>>> Please respect the rules. And do you really need the break the line here?
>>>
>>>> + irq = platform_get_irq(pdev, 1);
>>>> + if (irq < 0) {
>>>> + error = -ENODEV;
>>>
>>> Please propagate the error instead.
>> Sure, will do.
> On closer examination the above is consistent with the existing
> error handling for another call to platform_get_irq() in the same function.
> Shall we fix that first?
Yes, and I'll look into that.
WBR, Sergei
next prev parent reply other threads:[~2015-08-28 10:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 9:24 [PATCH/RFC 04/10] ravb: Add support for r8a7795 SoC Simon Horman
2015-08-27 11:01 ` Geert Uytterhoeven
2015-08-27 11:03 ` Sergei Shtylyov
2015-08-28 1:42 ` Simon Horman
2015-08-28 2:01 ` Simon Horman
2015-08-28 2:13 ` Simon Horman
2015-08-28 8:27 ` Simon Horman
2015-08-28 8:35 ` Geert Uytterhoeven
2015-08-28 9:09 ` Simon Horman
2015-08-28 10:20 ` Sergei Shtylyov
2015-08-28 10:30 ` Sergei Shtylyov [this message]
2015-08-28 10:51 ` Sergei Shtylyov
2015-08-28 11:46 ` Sergei Shtylyov
2015-08-28 12:05 ` Simon Horman
2015-08-28 12:42 ` Sergei Shtylyov
2015-08-28 13:21 ` Sergei Shtylyov
2015-09-02 2:13 ` Simon Horman
2015-09-02 2:13 ` Simon Horman
2015-09-02 2:14 ` Simon Horman
2015-09-02 7:26 ` Geert Uytterhoeven
2015-09-02 7:43 ` Simon Horman
2015-09-07 23:06 ` Sergei Shtylyov
2015-09-08 20:52 ` Sergei Shtylyov
2015-09-09 1:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E03838.3080604@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.