From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] x86: adjustments to memory_add()
Date: Fri, 28 Aug 2015 15:31:33 +0100 [thread overview]
Message-ID: <55E070C5.9050308@citrix.com> (raw)
In-Reply-To: <55E08C6C020000780009DDDF@prv-mh.provo.novell.com>
On 28/08/15 15:29, Jan Beulich wrote:
>>>> On 28.08.15 at 16:11, <andrew.cooper3@citrix.com> wrote:
>> On 28/08/15 14:54, Jan Beulich wrote:
>>> The function should clean up after a failed map_pages_to_xen().
>>>
>>> Sharing the M2P table with Dom0 needs to happen before adding
>>> the new pages to the heap.
>> Why? Does this not create a race where dom0 can observe the new mfns
>> before they are ready to use?
> No, observing the MFNs is fine as long as no domain can use them.
> The race is the other way around: Not having the M2P in place
> when the pages could already be handed out from the allocator is
> a problem.
Ah yes - of course. Would you mind extending the patch description to
include this.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-08-28 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 13:54 [PATCH] x86: adjustments to memory_add() Jan Beulich
2015-08-28 14:11 ` Andrew Cooper
2015-08-28 14:29 ` Jan Beulich
2015-08-28 14:31 ` Andrew Cooper [this message]
2015-08-31 11:44 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E070C5.9050308@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.