From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVL29-0007WA-5W for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:53:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVL25-0003qX-U7 for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:53:37 -0400 Received: from greensocs.com ([193.104.36.180]:49015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVL25-0003pe-Kp for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:53:33 -0400 Message-ID: <55E075E9.9090406@greensocs.com> Date: Fri, 28 Aug 2015 16:53:29 +0200 From: Frederic Konrad MIME-Version: 1.0 References: <1439397664-70734-1-git-send-email-pbonzini@redhat.com> <1439397664-70734-4-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] replace spinlock by QemuMutex. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Paolo Bonzini Cc: mttcg@greensocs.com, QEMU Developers On 28/08/2015 16:49, Peter Maydell wrote: > On 12 August 2015 at 17:40, Paolo Bonzini wrote: >> From: KONRAD Frederic >> >> spinlock is only used in two cases: >> * cpu-exec.c: to protect TranslationBlock >> * mem_helper.c: for lock helper in target-i386 (which seems broken). >> >> It's a pthread_mutex_t in user-mode so better using QemuMutex directly in this >> case. >> It allows as well to reuse tb_lock mutex of TBContext in case of multithread >> TCG. > The line wrapping in this commit message (and the grammar) looks a bit off... > >> Signed-off-by: KONRAD Frederic >> Message-Id: <1439220437-23957-5-git-send-email-fred.konrad@greensocs.com> >> Signed-off-by: Paolo Bonzini >> --- >> cpu-exec.c | 15 +++------------ >> include/exec/exec-all.h | 4 ++-- >> linux-user/main.c | 6 +++--- >> target-i386/cpu.h | 3 +++ >> target-i386/mem_helper.c | 25 ++++++++++++++++++++++--- >> target-i386/translate.c | 2 ++ >> tcg/tcg.h | 4 ++++ >> translate-all.c | 34 ++++++++++++++++++++++++++++++++++ >> 8 files changed, 73 insertions(+), 20 deletions(-) > After this commit it looks like we have no users of spinlock_t > at all. It would be good to have a followup patch which deleted > include/exec/spinlock.h. Seems Paolo forget to pick up the following patch from the mttcg tree: "remove unused spinlock." https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg01129.html Thanks, Fred > Otherwise > Reviewed-by: Peter Maydell > > thanks > -- PMM