From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 7241771633 for ; Fri, 28 Aug 2015 15:45:33 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id t7SFjWSV025358 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 28 Aug 2015 08:45:32 -0700 (PDT) Received: from [172.25.44.6] (172.25.44.6) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.235.1; Fri, 28 Aug 2015 08:45:32 -0700 To: Khem Raj References: <1440731387-19733-1-git-send-email-Randy.MacLeod@windriver.com> <55DFD2BC.7070405@windriver.com> From: Randy MacLeod Message-ID: <55E0821B.6000207@windriver.com> Date: Fri, 28 Aug 2015 11:45:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.25.44.6] Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] gcc-source: exlude from world X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 15:45:36 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 2015-08-27 11:27 PM, Khem Raj wrote: > On Thu, Aug 27, 2015 at 8:17 PM, Randy MacLeod > wrote: >> >> I've sent the parent email to fix >> $ bitbake -c world. >> I've confirmed that my change works for: >> $ bitbake -c configure world >> >> I wasn't sure if I should leave gcc-source as >> is or change it to be similar to kernel-devsrc >> because meta/recipes-devtools/gcc/gcc-source.inc does: >> >> deltask do_configure >> deltask do_compile >> deltask do_package > > if a task is deleted and you do -c then you should get an > error. deltask would create no stamps as opposed to noop tasks. May be > it can be turned into warning ( not convinced for that too) > but excluding it world doesn't sound a good solution here. I'd be happy to change the deltask lines to do_foo[noexec] = "1" if people agree on that. Would that work for you Khem? The kernel-devsrc and gcc-source packages are really a different class of recipes from -native or target and if we had more than two of them, we should create a class to encapsulate their behaviour and ensure that they don't break bitbake -c world builds. I haven't tried that yet but I expect the class would just have the do_foo[noexec] = "1" so you don't have to type it in each of the two recipes of this type that we currently have! :) I'd like to do the: do_foo[noexec] = "1" now and figure out how to handle foo-source in 2.1. Agreed? I'll include the [YOCTO #7878] in a v2 once I get some guidance on what is acceptable. ../Randy > >> ... >> >> whereas meta/recipes-kernel/linux/kernel-devsrc.bb does: >> # There's nothing to do here, except install the source where we can package >> it >> do_fetch[noexec] = "1" >> do_unpack[noexec] = "1" >> do_patch[noexec] = "1" >> ... >> >> The kernel-devsrc approach doesn't break world builds >> but it's probably slightly less efficient. >> >> Also do people care about consistency in naming: >> gcc-source.inc vs >> kernel-devsrc.bb >> ? There are only two such 'source' packages so it's not a big deal. >> >> ../Randy >> >> >> >> On 2015-08-27 11:09 PM, Randy MacLeod wrote: >>> >>> Exclude all versions of gcc-source from world builds so that: >>> bitbake -c world >>> will work. gcc-source deletes most bitbake build stages >>> since it is a source-only package. >>> >>> Signed-off-by: Randy MacLeod >>> --- >>> meta/recipes-devtools/gcc/gcc-source_4.8.bb | 2 ++ >>> meta/recipes-devtools/gcc/gcc-source_4.9.bb | 2 ++ >>> meta/recipes-devtools/gcc/gcc-source_5.2.bb | 2 ++ >>> 3 files changed, 6 insertions(+) >>> >>> diff --git a/meta/recipes-devtools/gcc/gcc-source_4.8.bb >>> b/meta/recipes-devtools/gcc/gcc-source_4.8.bb >>> index 234b82e..b890fa3 100644 >>> --- a/meta/recipes-devtools/gcc/gcc-source_4.8.bb >>> +++ b/meta/recipes-devtools/gcc/gcc-source_4.8.bb >>> @@ -1,2 +1,4 @@ >>> require recipes-devtools/gcc/gcc-${PV}.inc >>> require recipes-devtools/gcc/gcc-source.inc >>> + >>> +EXCLUDE_FROM_WORLD = "1" >>> diff --git a/meta/recipes-devtools/gcc/gcc-source_4.9.bb >>> b/meta/recipes-devtools/gcc/gcc-source_4.9.bb >>> index 234b82e..b890fa3 100644 >>> --- a/meta/recipes-devtools/gcc/gcc-source_4.9.bb >>> +++ b/meta/recipes-devtools/gcc/gcc-source_4.9.bb >>> @@ -1,2 +1,4 @@ >>> require recipes-devtools/gcc/gcc-${PV}.inc >>> require recipes-devtools/gcc/gcc-source.inc >>> + >>> +EXCLUDE_FROM_WORLD = "1" >>> diff --git a/meta/recipes-devtools/gcc/gcc-source_5.2.bb >>> b/meta/recipes-devtools/gcc/gcc-source_5.2.bb >>> index 234b82e..b890fa3 100644 >>> --- a/meta/recipes-devtools/gcc/gcc-source_5.2.bb >>> +++ b/meta/recipes-devtools/gcc/gcc-source_5.2.bb >>> @@ -1,2 +1,4 @@ >>> require recipes-devtools/gcc/gcc-${PV}.inc >>> require recipes-devtools/gcc/gcc-source.inc >>> + >>> +EXCLUDE_FROM_WORLD = "1" >>> >> >> >> -- >> # Randy MacLeod. SMTS, Linux, Wind River >> Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, >> K2K 2W5 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core -- # Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5