From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVS6d-0003ed-LE for qemu-devel@nongnu.org; Fri, 28 Aug 2015 18:26:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVS6a-0003Pm-Ev for qemu-devel@nongnu.org; Fri, 28 Aug 2015 18:26:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVS6a-0003PA-6n for qemu-devel@nongnu.org; Fri, 28 Aug 2015 18:26:40 -0400 References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com> <1438159544-6224-32-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <55E0E01E.5000708@redhat.com> Date: Fri, 28 Aug 2015 16:26:38 -0600 MIME-Version: 1.0 In-Reply-To: <1438159544-6224-32-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xO2TvQ0DRaAQXhu6aaDxFAFNMVpCu1S57" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 31/34] COLO: Add colo-set-checkpoint-period command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Markus Armbruster , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, amit.shah@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xO2TvQ0DRaAQXhu6aaDxFAFNMVpCu1S57 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/29/2015 02:45 AM, zhanghailiang wrote: > With this command, we can control the period of checkpoint, if > there is no comparison of net packets. >=20 > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > --- > hmp-commands.hx | 15 +++++++++++++++ > hmp.c | 7 +++++++ > hmp.h | 1 + > migration/colo.c | 11 ++++++++++- > qapi-schema.json | 13 +++++++++++++ > qmp-commands.hx | 22 ++++++++++++++++++++++ > stubs/migration-colo.c | 4 ++++ > 7 files changed, 72 insertions(+), 1 deletion(-) Interface review: > +++ b/qapi-schema.json > @@ -691,6 +691,19 @@ > { 'command': 'colo-lost-heartbeat' } > =20 > ## > +# @colo-set-checkpoint-period > +# > +# Set colo checkpoint period > +# > +# @value: period of colo checkpoint in ms > +# > +# Returns: nothing on success Redundant line; you could omit it. > +# > +# Since: 2.4 2.5 > +## > +{ 'command': 'colo-set-checkpoint-period', 'data': {'value': 'int'} } I hate write-only interfaces; where can I query the current period? > +++ b/stubs/migration-colo.c > @@ -52,3 +52,7 @@ void qmp_colo_lost_heartbeat(Error **errp) > " with --enable-colo option in order to support" > " COLO feature"); > } > + > +void qmp_colo_set_checkpoint_period(int64_t value, Error **errp) > +{ > +} Shouldn't the stub function set an error, rather than being a no-op? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xO2TvQ0DRaAQXhu6aaDxFAFNMVpCu1S57 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV4OAeAAoJEKeha0olJ0Nq98cH/2xdt0RjZvIjCzxOlh1F7kRl KpdfArtjX7UFMlAI58OsQts527FpLjnLkSZnsZrMmVtEkuEXwuvECG9fzstq+tiW tGbYskk7VA1nmAbseUPc806SAvS6zoN+HMAr47BIDYn8EFXT+Gupc61t6DocdQZE KDp5hcR8pJeOpR6jN9F1V0i4lbyzrxokly2SzrY7sTCFC3ecFBneGambqEcQz7Z0 lr1n9JW+xIuSS181hwUOreJtDfBLE3QyTKI2Nl/MfjbXCqIRfUTknOEkl5CL00JH FfQaI5Kc5GGPfEjutQkqKMqSooQsnCErOUUgUWI5YYXivloT6TmeSoWkjYdLNNc= =iXjN -----END PGP SIGNATURE----- --xO2TvQ0DRaAQXhu6aaDxFAFNMVpCu1S57--