From: Clemens Ladisch <clemens@ladisch.de>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org, ffado-devel@lists.sf.net,
Takashi Sakamoto <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH] ALSA: fireworks/bebob/dice/oxfw: fix substreams counting at vmalloc failure
Date: Sat, 29 Aug 2015 08:46:24 +0200 [thread overview]
Message-ID: <55E15540.9020401@ladisch.de> (raw)
In-Reply-To: <1440812326-6008-1-git-send-email-o-takashi@sakamocchi.jp>
Takashi Sakamoto wrote:
> In PCM core, when hw_params() in each driver returns error, the state of
> PCM substream is kept as 'open'. In this case, current drivers for sound
> units on IEEE 1394 bus doesn't decrement substream counter in hw_free()
> correctly. This causes these drivers to keep streams even if not
> required.
>
> This commit fixes this bug. When snd_pcm_lib_alloc_vmalloc_buffer()
> fails, hw_params function in each driver returns without incrementing the
> counter.
>
> Reported-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> sound/firewire/bebob/bebob_pcm.c | 20 ++++++++++++++++----
> sound/firewire/dice/dice-pcm.c | 18 ++++++++++++++----
> sound/firewire/fireworks/fireworks_pcm.c | 18 ++++++++++++++----
> sound/firewire/oxfw/oxfw-pcm.c | 17 +++++++++++++----
> 4 files changed, 57 insertions(+), 16 deletions(-)
next prev parent reply other threads:[~2015-08-29 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 1:38 [PATCH] ALSA: fireworks/bebob/dice/oxfw: fix substreams counting at vmalloc failure Takashi Sakamoto
2015-08-29 6:46 ` Clemens Ladisch [this message]
2015-08-29 7:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E15540.9020401@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.