From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-crypto@vger.kernel.org, David Howells <dhowells@redhat.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] crypto: Fix ASN.1 key handling for RSA akcipher
Date: Sat, 29 Aug 2015 07:28:36 -0700 [thread overview]
Message-ID: <55E1C194.1020608@intel.com> (raw)
In-Reply-To: <C966DBDA-0161-4523-A705-43D96C7B8A04@holtmann.org>
On 08/28/2015 05:54 PM, Marcel Holtmann wrote:
>> If you want to do this you should also update the existing RSA test vectors, because
>> > they are failing after this patch is applied.
> the test vectors have been failing no matter what. The crypto/rsakey.asn1 is actually broken as I explained in previous emails. That the ASN.1 parser accepted the test vectors was a bug which has been fixed now.
>
So that's a very nice bug, which makes things work nicely. I wish all the bugs were like this one ;)
prev parent reply other threads:[~2015-08-29 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 5:28 [PATCH] crypto: Fix ASN.1 key handling for RSA akcipher Marcel Holtmann
2015-08-28 9:20 ` Stephan Mueller
2015-08-28 15:44 ` Marcel Holtmann
2015-08-28 23:15 ` Tadeusz Struk
2015-08-29 0:54 ` Marcel Holtmann
2015-08-29 6:55 ` Herbert Xu
2015-08-29 14:34 ` Tadeusz Struk
2015-09-07 9:38 ` David Howells
2015-08-29 14:28 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E1C194.1020608@intel.com \
--to=tadeusz.struk@intel.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.