From: "Torsten Bögershausen" <tboegi@web.de>
To: David Turner <dturner@twopensource.com>,
git@vger.kernel.org, mhagger@alum.mit.edu, pclouds@gmail.com,
sunshine@sunshineco.com
Subject: Re: [PATCH v4 2/4] path: optimize common dir checking
Date: Sun, 30 Aug 2015 08:25:03 +0200 [thread overview]
Message-ID: <55E2A1BF.5080204@web.de> (raw)
In-Reply-To: <1440618365-20628-3-git-send-email-dturner@twopensource.com>
On 26.08.15 21:46, David Turner wrote:
> Instead of a linear search over common_list to check whether
> a path is common, use a trie. The trie search operates on
> path prefixes, and handles excludes.
>
> Signed-off-by: David Turner <dturner@twopensource.com>
> ---
> path.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++----
> t/t0060-path-utils.sh | 1 +
> 2 files changed, 213 insertions(+), 14 deletions(-)
>
> diff --git a/path.c b/path.c
> + child->len = root->len - i - 1;
> + if (child->len) {
> + child->contents = strndup(root->contents + i + 1,
> + child->len);
> }
Could we use xtrndup() instead of strndup() ?
(Otherwise it won't compile under Mac OS here)
next prev parent reply other threads:[~2015-08-30 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 19:46 [PATCH v4 0/4] per-worktree bisection refs David Turner
2015-08-26 19:46 ` [PATCH v4 1/4] refs: clean up common_list David Turner
2015-08-26 19:46 ` [PATCH v4 2/4] path: optimize common dir checking David Turner
2015-08-26 21:15 ` Junio C Hamano
2015-08-26 22:10 ` David Turner
2015-08-26 22:15 ` Junio C Hamano
2015-08-26 22:19 ` David Turner
2015-08-28 16:39 ` Junio C Hamano
2015-08-28 18:36 ` David Turner
2015-08-30 6:25 ` Torsten Bögershausen [this message]
2015-08-31 18:56 ` David Turner
2015-08-26 19:46 ` [PATCH v4 3/4] refs: make refs/worktree/* per-worktree David Turner
2015-08-26 19:46 ` [PATCH v4 4/4] bisect: make bisection refs per-worktree David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E2A1BF.5080204@web.de \
--to=tboegi@web.de \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.