Re: [PATCH 02/10] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath

[Hannes Reinecke <hare@suse.de>]

On 08/28/2015 09:53 PM, James Bottomley wrote:
> On Thu, 2015-08-27 at 14:16 +0200, Hannes Reinecke wrote:
>> @@ -158,7 +171,7 @@ store_dh_state(struct device *dev, struct device_attribute *attr,
>>  		/*
>>  		 * Attach to a device handler
>>  		 */
>> -		if (!(scsi_dh = get_device_handler(buf)))
>> +		if (!(scsi_dh = scsi_dh_lookup(buf)))
> 
> This one's a checkpatch error:
> 
> ERROR: do not use assignment in if condition
> #71: FILE: drivers/scsi/device_handler/scsi_dh.c:174:
> +               if (!(scsi_dh = scsi_dh_lookup(buf)))
> 
> 
> For very good reason.  The meaning is obvious from the previous code, so
> I fixed it up as
> 
> 		scsi_dh = scsi_dh_lookup(buf);
> 		if (!scsi_dh)
> 
> But running the series through checkpatch and acting on at least the
> errors would have been appreciated.
> 
You're right, sorry. Thanks for fixing it up.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html