From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWKbx-00085P-ML for qemu-devel@nongnu.org; Mon, 31 Aug 2015 04:38:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWKbt-0005r3-2i for qemu-devel@nongnu.org; Mon, 31 Aug 2015 04:38:41 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:36060 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWKbs-0005pr-Cb for qemu-devel@nongnu.org; Mon, 31 Aug 2015 04:38:37 -0400 References: <1440058448-27847-1-git-send-email-pl@kamp.de> <1440058448-27847-2-git-send-email-pl@kamp.de> <55D6C15E.2040805@redhat.com> From: Peter Lieven Message-ID: <55E41279.7070101@kamp.de> Date: Mon, 31 Aug 2015 10:38:17 +0200 MIME-Version: 1.0 In-Reply-To: <55D6C15E.2040805@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, Jeff Cody , Max Reitz , pbonzini@redhat.com, jsnow@redhat.com Am 21.08.2015 um 08:12 schrieb Eric Blake: > On 08/20/2015 01:14 AM, Peter Lieven wrote: >> If the backend storage is unresponsive and we cancel a request due to >> a timeout we cannot immediately destroy the AIOCB because the storage >> might complete the original request laster if it is responsive again. > s/laster/later/ > >> For this purpose allow to set the callback to NULL and ignore it in >> this case. >> >> Signed-off-by: Peter Lieven >> --- > I'll leave the technical review to others, I'm just pointing out grammar. > I am using this one for quite some time now. It seems a good step into solving the deadlock problem. The issue is we still need to make the ATAPI calls async. The OS is only spending 2-3 Minutes with DMA cancelling and then issues reads again so we still deadlock at the end. Peter