Re: [Qemu-devel] [PATCH] block/iscsi: validate block size returned from target

[Peter Lieven <pl@kamp.de>]

Am 14.08.2015 um 13:33 schrieb Peter Lieven:
> It has been reported that at least tgtd returns a block size of 0
> for LUN 0. To avoid running into divide by zero later on and protect
> against other problematic block sizes validate the block size right
> at connection time.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Andrey Korolyov <andrey@xdel.ru>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>   block/iscsi.c | 4 ++++
>   dtc           | 2 +-
>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 5002916..fac3a7a 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1214,6 +1214,10 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
>   
>       if (task == NULL || task->status != SCSI_STATUS_GOOD) {
>           error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> +    } else if (!iscsilun->block_size ||
> +               iscsilun->block_size % BDRV_SECTOR_SIZE) {
> +        error_setg(errp, "iSCSI: the target returned an invalid "
> +                   "block size of %d.", iscsilun->block_size);
>       }
>       if (task) {
>           scsi_free_scsi_task(task);

Ping