From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:33877 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbbHaKuW (ORCPT ); Mon, 31 Aug 2015 06:50:22 -0400 Message-ID: <55E43136.50107@xs4all.nl> Date: Mon, 31 Aug 2015 12:49:26 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Mauro Carvalho Chehab , Linux Media Mailing List CC: Mauro Carvalho Chehab Subject: Re: [PATCH v8 24/55] [media] media-entity: add a helper function to create interface References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/30/2015 05:06 AM, Mauro Carvalho Chehab wrote: > As we'll be adding other interface types in the future, put the > common interface create code on a separate function. > > Suggested-by: Hans Verkuil > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index 08239128fbc4..417673a32c21 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -851,6 +851,18 @@ struct media_pad *media_entity_remote_pad(struct media_pad *pad) > EXPORT_SYMBOL_GPL(media_entity_remote_pad); > > > +static void media_interface_init(struct media_device *mdev, > + struct media_interface *intf, > + u32 gobj_type, > + u32 intf_type, u32 flags) > +{ > + intf->type = intf_type; > + intf->flags = flags; > + INIT_LIST_HEAD(&intf->links); > + > + media_gobj_init(mdev, gobj_type, &intf->graph_obj); > +} > + > /* Functions related to the media interface via device nodes */ > > struct media_intf_devnode *media_devnode_create(struct media_device *mdev, > @@ -859,23 +871,16 @@ struct media_intf_devnode *media_devnode_create(struct media_device *mdev, > gfp_t gfp_flags) > { > struct media_intf_devnode *devnode; > - struct media_interface *intf; > > devnode = kzalloc(sizeof(*devnode), gfp_flags); > if (!devnode) > return NULL; > > - intf = &devnode->intf; > - > - intf->type = type; > - intf->flags = flags; > - INIT_LIST_HEAD(&intf->links); > - > devnode->major = major; > devnode->minor = minor; > > - media_gobj_init(mdev, MEDIA_GRAPH_INTF_DEVNODE, > - &devnode->intf.graph_obj); > + media_interface_init(mdev, &devnode->intf, MEDIA_GRAPH_INTF_DEVNODE, > + type, flags); > > return devnode; > } >