All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Michael Kerrisk (man-pages)"
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	GNU C Library
	<libc-alpha-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org>
Subject: Re: [patch] mallopt.3: Document M_ARENA_TEST, and M_ARENA_MAX.
Date: Mon, 31 Aug 2015 09:20:42 -0400	[thread overview]
Message-ID: <55E454AA.6080409@redhat.com> (raw)
In-Reply-To: <55E2F1BD.8050609-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 08/30/2015 08:06 AM, Michael Kerrisk (man-pages) wrote:
> diff --git a/man3/mallopt.3 b/man3/mallopt.3
> index c09e801..fd41bf0 100644
> --- a/man3/mallopt.3
> +++ b/man3/mallopt.3
> @@ -66,8 +66,8 @@ and since glibc 2.15 by default.
>  In some versions of the allocator there was no limit on the number
>  of created arenas (e.g., CentOS 5, RHEL 5).
>  
> -When running programs on newer glibc versions,
> -these applications may exhibit high contention when accessing arenas.
> +When employing newer glibc versions, applications may in
> +some cases exhibit high contention when accessing arenas.

OK.

>  In these cases, it may be beneficial to increase
>  .B M_ARENA_MAX
>  to match the number of threads.
> @@ -79,7 +79,7 @@ This is the limit, in number of arenas created, at which the system
>  configuration will be examined to evaluate a hard limit on the
>  number of created arenas.
>  The computed limit is implementation-defined
> -and is usually a multiple of the number of available cores.
> +and is usually a multiple of the number of available CPUs.

I like this. This is better than what I wrote, since a core is not
the right unit here, we are reading /sys/devices/system/cpu/online,
or /proc/stat or /proc/cpuinfo to compute the number of online cpus.

>  Once the limit is computed, the result is final and constrains
>  the total number of arenas.
>  See
 
Thanks for the commit and fixup! 

Cheers,
Carlos.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-31 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 16:05 [patch] mallopt.3: Document M_ARENA_TEST, and M_ARENA_MAX Carlos O'Donell
     [not found] ` <55DB40AE.7080405-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-30 12:06   ` Michael Kerrisk (man-pages)
     [not found]     ` <55E2F1BD.8050609-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-31 13:20       ` Carlos O'Donell [this message]
     [not found]         ` <55E454AA.6080409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-01 13:35           ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E454AA.6080409@redhat.com \
    --to=carlos-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=libc-alpha-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.