From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger Date: Mon, 31 Aug 2015 16:57:09 +0200 Message-ID: <55E46B45.8040909@metafoo.de> References: <1439246562-17515-1-git-send-email-daniel.baluta@intel.com> <1439246562-17515-5-git-send-email-daniel.baluta@intel.com> <55D1D786.2010407@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: knaack.h@gmx.de, linux-kernel@vger.kernel.org, octavian.purdila@intel.com, pebolle@tiscali.nl, patrick.porlan@intel.com, adriana.reus@intel.com, constantin.musca@intel.com, marten@intuitiveaerial.com, cristina.opriceana@gmail.com, pmeerw@pmeerw.net, hch@lst.de, viro@zeniv.linux.org.uk, akpm@linux-foundation.org To: Vladimir Barinov , Daniel Baluta , jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from smtp-out-225.synserver.de ([212.40.185.225]:1309 "EHLO smtp-out-200.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753106AbbHaO5O (ORCPT ); Mon, 31 Aug 2015 10:57:14 -0400 In-Reply-To: <55D1D786.2010407@cogentembedded.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/17/2015 02:45 PM, Vladimir Barinov wrote: > Hello Daniel, > > I've verified that your hrtimer trigger works. > > I have minor suggestions. > > Will not it be useful to have ability to stop/start hrtimer polling > not only during attach/detach trigger. > > f.e. writing 0 to sampling_frequency will hrtimer_cancel > and writing any valid frequency will hrtimer_start. What's the use case for this?