Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On 08/31/2015 05:30 AM, Michael S. Tsirkin wrote:
> On Mon, Aug 31, 2015 at 08:29:39AM +0000, Ouyang, Changchun wrote:

>>>>>>> On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote:
>>>>>>>> Based on patch by Nikolay Nikolaev:

When you start to have this much nested quoting,...

>>>>>>>> -269,7 +270,7 @@ static void vhost_net_stop_one(struct
>>>>>>>> vhost_net
>>>>> *net,
>>>>>>>>          for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
>>>>>>>>              const VhostOps *vhost_ops = net->dev.vhost_ops;
>>>>>>>>              int r = vhost_ops->vhost_call(&net->dev,
>>> VHOST_RESET_OWNER,

...line wrapping of the quotes gets funky and starts mis-attributing
portions of lines to the wrong quote level.

>> Vhost backend can't support the queues number as much as the guest/qemu requires,
>> I think you mean we should let qemu exit in such a case, right?   
> 
> Exactly.

And mis-attribution makes it that much harder to find the real content
being added further down in the middle of 28k of mostly-quoted message.

Please remember that it is okay to trim messages to the relevant
portions, to make it easier for readers to quickly get at the new content.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]