From: Jonathan Cameron <jic23@kernel.org>
To: Duan Andy <fugang.duan@freescale.com>,
Sanchayan Maity <maitysanchayan@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid ADC
Date: Mon, 31 Aug 2015 16:20:08 +0100 [thread overview]
Message-ID: <55E470A8.4000200@kernel.org> (raw)
In-Reply-To: <BN3PR0301MB121977040608F337E69ADADEF5660@BN3PR0301MB1219.namprd03.prod.outlook.com>
On 20/08/15 07:50, Duan Andy wrote:
> From: Sanchayan Maity <maitysanchayan@gmail.com> Sent: Monday, August 17, 2015 11:52 PM
>> To: jic23@kernel.org; linux-iio@vger.kernel.org
>> Cc: stefan@agner.ch; Duan Fugang-B38611; pmeerw@pmeerw.net; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Sanchayan
>> Maity
>> Subject: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid
>> ADC
>>
>> This patch adds support for IIO buffer to the Vybrid ADC driver.
>> IIO triggered buffer infrastructure along with iio sysfs trigger is used
>> to leverage continuous sampling support provided by the ADC block.
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>>
>> Changes since v3:
>> Fix iio_buffer_setup_ops for postenable and predisable functions to match
>> pairwise. Before this the predisable work was being done in postdisable.
>>
>> Changes since v2:
>> 1. Fix the wrong buffer size for statically allocated buffer 2. Drop the
>> use of .address field from the iio_chan_spec 3. Use iio_buffer_enabled
>> call inside the lock 4. Drop wrapper function around iio_trigered_*
>> function calls 5. Drop Kconfig select of sysfs trigger 6. Drop Kconfig
>> select IIO_TRIGGER as it is already selected by IIO_TRIGGERED_BUFFER
>>
>> Changes since v1:
>> 1. Use a fixed size buffer instead of kmalloc allocated during update
>> scan mode 2. Remove a write to read only register ADC_HS (COCO bit)
>>
>> drivers/iio/adc/Kconfig | 2 +
>> drivers/iio/adc/vf610_adc.c | 105
>> +++++++++++++++++++++++++++++++++++++++++---
>> 2 files changed, 100 insertions(+), 7 deletions(-)
>>
>
> The version is fine for me. Thanks for your effort.
>
> Acked-by: Fugang Duan <B38611@freescale.com>
Applied to the togreg branch of iio.git - will be initially pushed out
as testing for the autobuilders to play with it.
Thanks,
Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid ADC
Date: Mon, 31 Aug 2015 16:20:08 +0100 [thread overview]
Message-ID: <55E470A8.4000200@kernel.org> (raw)
In-Reply-To: <BN3PR0301MB121977040608F337E69ADADEF5660@BN3PR0301MB1219.namprd03.prod.outlook.com>
On 20/08/15 07:50, Duan Andy wrote:
> From: Sanchayan Maity <maitysanchayan@gmail.com> Sent: Monday, August 17, 2015 11:52 PM
>> To: jic23 at kernel.org; linux-iio at vger.kernel.org
>> Cc: stefan at agner.ch; Duan Fugang-B38611; pmeerw at pmeerw.net; linux-
>> kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Sanchayan
>> Maity
>> Subject: [PATCH v4] iio: adc: vf610: Add IIO buffer support for Vybrid
>> ADC
>>
>> This patch adds support for IIO buffer to the Vybrid ADC driver.
>> IIO triggered buffer infrastructure along with iio sysfs trigger is used
>> to leverage continuous sampling support provided by the ADC block.
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>>
>> Changes since v3:
>> Fix iio_buffer_setup_ops for postenable and predisable functions to match
>> pairwise. Before this the predisable work was being done in postdisable.
>>
>> Changes since v2:
>> 1. Fix the wrong buffer size for statically allocated buffer 2. Drop the
>> use of .address field from the iio_chan_spec 3. Use iio_buffer_enabled
>> call inside the lock 4. Drop wrapper function around iio_trigered_*
>> function calls 5. Drop Kconfig select of sysfs trigger 6. Drop Kconfig
>> select IIO_TRIGGER as it is already selected by IIO_TRIGGERED_BUFFER
>>
>> Changes since v1:
>> 1. Use a fixed size buffer instead of kmalloc allocated during update
>> scan mode 2. Remove a write to read only register ADC_HS (COCO bit)
>>
>> drivers/iio/adc/Kconfig | 2 +
>> drivers/iio/adc/vf610_adc.c | 105
>> +++++++++++++++++++++++++++++++++++++++++---
>> 2 files changed, 100 insertions(+), 7 deletions(-)
>>
>
> The version is fine for me. Thanks for your effort.
>
> Acked-by: Fugang Duan <B38611@freescale.com>
Applied to the togreg branch of iio.git - will be initially pushed out
as testing for the autobuilders to play with it.
Thanks,
Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-08-31 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 9:05 [PATCH v3] Add continuous sampling with IIO buffers for Vybrid Sanchayan Maity
2015-08-11 9:05 ` Sanchayan Maity
2015-08-11 9:05 ` [PATCH v3] iio: adc: vf610: Add IIO buffer support for Vybrid ADC Sanchayan Maity
2015-08-11 9:05 ` Sanchayan Maity
2015-08-15 20:24 ` Jonathan Cameron
2015-08-15 20:24 ` Jonathan Cameron
2015-08-17 13:56 ` maitysanchayan
2015-08-17 13:56 ` maitysanchayan at gmail.com
2015-08-17 15:51 ` [PATCH v4] " Sanchayan Maity
2015-08-17 15:51 ` Sanchayan Maity
2015-08-20 6:38 ` maitysanchayan
2015-08-20 6:38 ` maitysanchayan at gmail.com
2015-08-20 6:50 ` Duan Andy
2015-08-20 6:50 ` Duan Andy
2015-08-31 15:20 ` Jonathan Cameron [this message]
2015-08-31 15:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E470A8.4000200@kernel.org \
--to=jic23@kernel.org \
--cc=fugang.duan@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.