All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v6] imx: imx7d: initial arch level support
Date: Mon, 31 Aug 2015 18:00:40 +0200	[thread overview]
Message-ID: <55E47A28.4080401@denx.de> (raw)
In-Reply-To: <1440803302-11840-1-git-send-email-aalonso@freescale.com>

Hi Adrian,

On 29/08/2015 01:08, Adrian Alonso wrote:
> * Add system arch level header files
>   - imx-regs.h: iMX7D SoC system architecture registers
>   - crm_regs.h: Clock control module registers
>   - sys_proto.h: helper callback function for SoC setup
> 
> Signed-off-by: Adrian Alonso <aalonso@freescale.com>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Signed-off-by: Ye.Li <B37916@freescale.com>
> ---
> Changes for V2: Split patch to easier review process
> - Add system arch register definitions
> Changes for V3: Resend
> Changes for V4: Resend
> Changes for V5: Resend
> Changes for V6:
> - Add common settings helper function definitions in sys_proto.h

[snip]

> +#endif /* __ASM_ARCH_MX7_IMX_REGS_H__ */
> diff --git a/arch/arm/include/asm/arch-mx7/sys_proto.h b/arch/arm/include/asm/arch-mx7/sys_proto.h
> new file mode 100644
> index 0000000..6e31594
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-mx7/sys_proto.h
> @@ -0,0 +1,51 @@
> +/*
> + * Copyright (C) 2015 Freescale Semiconductor, Inc.
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#ifndef _SYS_PROTO_H_
> +#define _SYS_PROTO_H_
> +
> +#include <asm/imx-common/regs-common.h>
> +#include "../arch-imx/cpu.h"
> +
> +#define is_soc_rev(rev)		((int)((get_cpu_rev() & 0xFF) - rev))
> +u32 get_cpu_rev(void);
> +u32 get_cpu_speed_grade_hz(void);
> +u32 get_cpu_temp_grade(int *minc, int *maxc);
> +
> +/* returns MXC_CPU_ value */
> +#define cpu_type(rev) (((rev) >> 12)&0xff)
> +#define soc_type(rev) (((rev) >> 12) & 0xf0)
> +#define get_soc_type()  (soc_type(get_cpu_rev()))
> +
> +/* use with MXC_CPU_ constants */
> +#define is_cpu_type(cpu) (cpu_type(get_cpu_rev()) == cpu)
> +#define is_soc_type(soc) (get_soc_type() == soc)
> +
> +const char *get_imx_type(u32 imxtype);
> +unsigned imx_ddr_size(void);
> +void set_wdog_reset(struct wdog_regs *wdog);
> +
> +void init_aips(void);
> +void init_src(void);
> +void imx_set_wdog_powerdown(bool enable);
> +

I am confused...Peng has reordered sys_proto.h splitting in a common
part ./arch/arm/include/asm/imx-common/sys_proto.h and in a cpu part.

The common part contains the prototypes valid for all i.MXes. You have
posted again a file with all prototypes, and you get rid of the common one.


> +/*
> + * Initializes on-chip ethernet controllers.
> + * to override, implement board_eth_init()
> + */
> +
> +int fecmxc_initialize(bd_t *bis);
> +u32 get_ahb_clk(void);
> +u32 get_periph_clk(void);
> +
> +int mxs_reset_block(struct mxs_register_32 *reg);
> +int mxs_wait_mask_set(struct mxs_register_32 *reg,
> +		       uint32_t mask,
> +		       unsigned int timeout);
> +int mxs_wait_mask_clr(struct mxs_register_32 *reg,
> +		       uint32_t mask,
> +		       unsigned int timeout);
> +#endif
> 

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2015-08-31 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 23:08 [U-Boot] [PATCH][v6] imx: imx7d: initial arch level support Adrian Alonso
2015-08-31 16:00 ` Stefano Babic [this message]
2015-08-31 16:22   ` Alonso Adrian
2015-08-31 16:32     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E47A28.4080401@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.