From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bn1bon0089.outbound.protection.outlook.com ([157.56.111.89] helo=na01-bn1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZWSz1-0005my-9l for linux-mtd@lists.infradead.org; Mon, 31 Aug 2015 17:35:04 +0000 Message-ID: <55E48F3D.3030800@opensource.altera.com> Date: Mon, 31 Aug 2015 12:30:37 -0500 From: Graham Moore MIME-Version: 1.0 To: Marek Vasut CC: , Alan Tull , Brian Norris , David Woodhouse , Dinh Nguyen , "Vikas MANOCHA" , Yves Vandervennet , Subject: Re: [PATCH 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller. References: <1440148851-14621-1-git-send-email-marex@denx.de> <1440148851-14621-2-git-send-email-marex@denx.de> In-Reply-To: <1440148851-14621-2-git-send-email-marex@denx.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Marek, Having some compile issues...see below On 08/21/2015 04:20 AM, Marek Vasut wrote: > From: Graham Moore > > Add support for the Cadence QSPI controller. This controller is > present in the Altera SoCFPGA SoCs and this driver has been tested > on the Cyclone V SoC. > > Signed-off-by: Graham Moore > Signed-off-by: Marek Vasut [...] > +static int cqspi_set_protocol(struct spi_nor *nor, enum spi_protocol proto) > +{ > + struct cqspi_flash_pdata *f_pdata = nor->priv; > + > + switch (proto) { > + case SPI_PROTO_1_1_1: > + case SPI_PROTO_1_1_2: > + case SPI_PROTO_1_1_4: > + case SPI_PROTO_1_2_2: > + case SPI_PROTO_1_4_4: > + f_pdata->inst_width = CQSPI_INST_TYPE_SINGLE; > + break; > + case SPI_PROTO_2_2_2: > + f_pdata->inst_width = CQSPI_INST_TYPE_DUAL; > + break; > + case SPI_PROTO_4_4_4: > + f_pdata->inst_width = CQSPI_INST_TYPE_QUAD; > + break; > + default: > + return -EINVAL; > + } > + > + switch (proto) { > + case SPI_PROTO_1_1_1: > + case SPI_PROTO_1_1_2: > + case SPI_PROTO_1_1_4: > + f_pdata->addr_width = CQSPI_INST_TYPE_SINGLE; > + break; > + case SPI_PROTO_1_2_2: > + case SPI_PROTO_2_2_2: > + f_pdata->addr_width = CQSPI_INST_TYPE_DUAL; > + break; > + case SPI_PROTO_1_4_4: > + case SPI_PROTO_4_4_4: > + f_pdata->addr_width = CQSPI_INST_TYPE_QUAD; > + break; > + default: > + return -EINVAL; > + } > + > + return 0; > +} > + I think you have some other patches in your tree, the above doesn't compile on l2-mtd/master: ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:57: warning: ‘enum spi_protocol’ declared inside parameter list [enabled by default] ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:57: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:70: error: parameter 2 (‘proto’) has incomplete type ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:12: error: function declaration isn’t a prototype [-Werror=strict-prototypes] ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c: In function ‘cqspi_set_protocol’: ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:706:7: error: ‘SPI_PROTO_1_1_1’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:706:7: note: each undeclared identifier is reported only once for each function it appears in ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:707:7: error: ‘SPI_PROTO_1_1_2’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:708:7: error: ‘SPI_PROTO_1_1_4’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:709:7: error: ‘SPI_PROTO_1_2_2’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:710:7: error: ‘SPI_PROTO_1_4_4’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:713:7: error: ‘SPI_PROTO_2_2_2’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:716:7: error: ‘SPI_PROTO_4_4_4’ undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c: In function ‘cqspi_setup_flash’: ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:1087:6: error: ‘struct spi_nor’ has no member named ‘dn’ ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:1096:6: error: ‘struct spi_nor’ has no member named ‘set_protocol’ [...] Regards, Graham From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graham Moore Subject: Re: [PATCH 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller. Date: Mon, 31 Aug 2015 12:30:37 -0500 Message-ID: <55E48F3D.3030800@opensource.altera.com> References: <1440148851-14621-1-git-send-email-marex@denx.de> <1440148851-14621-2-git-send-email-marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1440148851-14621-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marek Vasut Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Alan Tull , Brian Norris , David Woodhouse , Dinh Nguyen , Vikas MANOCHA , Yves Vandervennet , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Marek, Having some compile issues...see below On 08/21/2015 04:20 AM, Marek Vasut wrote: > From: Graham Moore > > Add support for the Cadence QSPI controller. This controller is > present in the Altera SoCFPGA SoCs and this driver has been tested > on the Cyclone V SoC. > > Signed-off-by: Graham Moore > Signed-off-by: Marek Vasut [...] > +static int cqspi_set_protocol(struct spi_nor *nor, enum spi_protocol= proto) > +{ > + struct cqspi_flash_pdata *f_pdata =3D nor->priv; > + > + switch (proto) { > + case SPI_PROTO_1_1_1: > + case SPI_PROTO_1_1_2: > + case SPI_PROTO_1_1_4: > + case SPI_PROTO_1_2_2: > + case SPI_PROTO_1_4_4: > + f_pdata->inst_width =3D CQSPI_INST_TYPE_SINGLE; > + break; > + case SPI_PROTO_2_2_2: > + f_pdata->inst_width =3D CQSPI_INST_TYPE_DUAL; > + break; > + case SPI_PROTO_4_4_4: > + f_pdata->inst_width =3D CQSPI_INST_TYPE_QUAD; > + break; > + default: > + return -EINVAL; > + } > + > + switch (proto) { > + case SPI_PROTO_1_1_1: > + case SPI_PROTO_1_1_2: > + case SPI_PROTO_1_1_4: > + f_pdata->addr_width =3D CQSPI_INST_TYPE_SINGLE; > + break; > + case SPI_PROTO_1_2_2: > + case SPI_PROTO_2_2_2: > + f_pdata->addr_width =3D CQSPI_INST_TYPE_DUAL; > + break; > + case SPI_PROTO_1_4_4: > + case SPI_PROTO_4_4_4: > + f_pdata->addr_width =3D CQSPI_INST_TYPE_QUAD; > + break; > + default: > + return -EINVAL; > + } > + > + return 0; > +} > + I think you have some other patches in your tree, the above doesn't=20 compile on l2-mtd/master: ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:57: warning: =91enum= =20 spi_protocol=92 declared inside parameter list [enabled by default] ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:57: warning: its=20 scope is only this definition or declaration, which is probably not wha= t=20 you want [enabled by default] ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:70: error: parameter= =20 2 (=91proto=92) has incomplete type ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:701:12: error: function=20 declaration isn=92t a prototype [-Werror=3Dstrict-prototypes] ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c: In function=20 =91cqspi_set_protocol=92: ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:706:7: error:=20 =91SPI_PROTO_1_1_1=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:706:7: note: each=20 undeclared identifier is reported only once for each function it appear= s in ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:707:7: error:=20 =91SPI_PROTO_1_1_2=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:708:7: error:=20 =91SPI_PROTO_1_1_4=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:709:7: error:=20 =91SPI_PROTO_1_2_2=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:710:7: error:=20 =91SPI_PROTO_1_4_4=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:713:7: error:=20 =91SPI_PROTO_2_2_2=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:716:7: error:=20 =91SPI_PROTO_4_4_4=92 undeclared (first use in this function) ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c: In function=20 =91cqspi_setup_flash=92: ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:1087:6: error: =91struct= =20 spi_nor=92 has no member named =91dn=92 ~/l2-mtd/drivers/mtd/spi-nor/cadence-quadspi.c:1096:6: error: =91struct= =20 spi_nor=92 has no member named =91set_protocol=92 [...] Regards, Graham -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html