From: David Ahern <dsa@cumulusnetworks.com>
To: Tom Herbert <tom@herbertland.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Shrijeet Mukherjee <shm@cumulusnetworks.com>
Subject: Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg
Date: Mon, 31 Aug 2015 11:49:55 -0600 [thread overview]
Message-ID: <55E493C3.1000102@cumulusnetworks.com> (raw)
In-Reply-To: <CALx6S36YTzCRDQUArzDv5sXHc6wgKxFnxNAauAGj74R_nYQabA@mail.gmail.com>
On 8/31/15 11:22 AM, Tom Herbert wrote:
> It's a major departure from current convention. The source address of
> the packet should be set before doing ip_send_skb. In UDP unconnected
> case ip_route_output_flow calls inet_select_addr. AKAIK there is no
> provision for not setting the source address and relying on the output
> device to do this in its transmit routine.
BTW, one other clarification the code setting the source address is NOT
in the xmit function but the dst.output function. The VRF device uses a
dst to direct packets to it. The output function (equivalent to
ip_output) is what sets the source address if necessary.
next prev parent reply other threads:[~2015-08-31 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 16:29 [PATCH net-next] net: Remove VRF change to udp_sendmsg David Ahern
2015-08-31 17:02 ` Tom Herbert
2015-08-31 17:05 ` David Ahern
2015-08-31 17:22 ` Tom Herbert
2015-08-31 17:40 ` David Ahern
2015-08-31 17:58 ` Tom Herbert
2015-08-31 17:49 ` David Ahern [this message]
2015-08-31 19:44 ` David Miller
2015-08-31 20:44 ` David Ahern
2015-09-08 20:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E493C3.1000102@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.