Re: [PATCH v6 14/31] xen/arm: ITS: Initialize physical ITS and export lpi support

[Julien Grall <julien.grall@citrix.com>]

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@gmail.com wrote:
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index 6ece7cc..15c76d0 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -283,6 +283,8 @@ extern void gic_dump_info(struct vcpu *v);
>
>   /* Number of interrupt lines */
>   extern unsigned int gic_number_lines(void);
> +/* LPI support info */
> +bool_t gic_lpi_supported(void);

I looked to all the usage of gic_lpi_supported in the code and none of 
them require a new function in the common framework:

	- patch #22: you should add a parameter to vgic_v3_setup_hw in order to 
know whether LPIs and/or ITS is supported.
	- patch #30: the call of gic_lpi_supported should go in the GICv3 
implementation of the callback.

So I would be in favor to drop it rather introducing yet another field.

Note, that I will comment further on both patches in each of them.

>
>   /* IRQ translation function for the device tree */
>   int gic_irq_xlate(const u32 *intspec, unsigned int intsize,
> @@ -302,6 +304,8 @@ struct gic_info {
>       const struct dt_device_node *node;
>       /* Number of IRQ ID bits supported */
>       uint32_t nr_id_bits;
> +    /* LPIs are support information */
> +    bool_t lpi_supported;
>   };
>
>   struct gic_hw_operations {
>

-- 
Julien Grall