All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	"Kershner, David A" <David.Kershner@unisys.com>,
	Ben Romer <benjamin.romer@unisys.com>
Subject: Re: [PATCH] mei, make modules.alias UUID information easier to read
Date: Mon, 31 Aug 2015 20:09:58 -0400	[thread overview]
Message-ID: <55E4ECD6.5010006@redhat.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B3D43214F@hasmsx108.ger.corp.intel.com>



On 08/29/2015 05:21 PM, Winkler, Tomas wrote:
>>
>> Hi Prarit,
>>
>> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote:
>>> Heikki, Tomas?
>>
>> I'm afraid I don't know much about Intel's Management Engine
>> Interface. Looks like the driver is from Samuel (CC'd) so I'm guessing
>> he is the person you wanted comments from and not me.
>>
> 
> The patch was done against the master branch instead of char-misc-next so it doesn't apply. Anyhow I've rebased it already and I'm testing it. 
> I will probably re-post it, with your permission with my other mei bus fixes.
> 

Yep, only requires some minor adjustments in order to apply to char-misc-next.
Please repost when you can.  FYI: this is needed to bring drivers/staging/unisys
out of the staging directory.

> BTW, I took the inspiration from vmbus in regards to uuid  representation so it if the uuid sting hurts you, you may fix vmbus as well.  I don't have any  vmbus setup and I try not to fix things I cannot check.
> 

I didn't recall other users of add_uuid() but took a look anway.

do_vmbus_entry() doesn't call add_uuid() like do_mei_entry() does.  However,
the vmbus code should also just simply use add_uuid().  I can do that after
this patch gets into the kernel, as it isn't absolutely necessary to fix like
do_mei_entry().  It should be a trivial drivers/hv patch to fix all
that up.

P.

  parent reply	other threads:[~2015-09-01  0:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 13:05 [PATCH] mei, make modules.alias UUID information easier to read Prarit Bhargava
2015-08-28 11:50 ` Prarit Bhargava
2015-08-28 12:46   ` Heikki Krogerus
2015-08-29 21:21     ` Winkler, Tomas
2015-08-30 17:36       ` Prarit Bhargava
2015-08-31  7:17         ` Winkler, Tomas
2015-09-01  0:09       ` Prarit Bhargava [this message]
2015-09-21  2:25 ` Greg Kroah-Hartman
2015-09-21  8:13   ` Winkler, Tomas
  -- strict thread matches above, loose matches on Subject: below --
2015-08-07 14:06 Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E4ECD6.5010006@redhat.com \
    --to=prarit@redhat.com \
    --cc=David.Kershner@unisys.com \
    --cc=benjamin.romer@unisys.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.