From: Adrian Hunter <adrian.hunter@intel.com>
To: "平松雅巳 / HIRAMATU，MASAMI" <masami.hiramatsu.pt@hitachi.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Denys Vlasenko <dvlasenk@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Qiaowei Ren <qiaowei.ren@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/4] perf tools: Add a test for decoding of new x86 instructions
Date: Tue, 01 Sep 2015 11:17:34 +0300 [thread overview]
Message-ID: <55E55F1E.6030804@intel.com> (raw)
In-Reply-To: <50399556C9727B4D88A595C8584AAB37524FD276@GSjpTKYDCembx32.service.hitachi.net>
On 01/09/15 03:18, 平松雅巳 / HIRAMATU，MASAMI wrote:
>> From: Adrian Hunter [mailto:adrian.hunter@intel.com]
>>
>> Add a new test titled:
>>
>> Test x86 instruction decoder - new instructions
>>
>> The purpose of this test is to check the instruction decoder
>> after new instructions have been added. Initially, MPX
>> instructions are tested which are already supported, but the
>> definitions in x86-opcode-map.txt will be tweaked in a
>> subsequent patch, after which this test can be run to verify
>> those changes.
>
> Hmm, btw, why should this test in perf? It seems that we need
> this test in kselftest or build-time selftest.
> I prefer to put this in arch/x86/tools/ or lib/. What would you
> think ?
There are 2 reasons perf tools needs a test:
1. perf tools is source code independent from the kernel i.e. it has its
own copy of the instruction decoder.
2. perf tools test also tests the Intel PT decoder's categorization of
instructions.
next prev parent reply other threads:[~2015-09-01 8:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 13:58 [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions Adrian Hunter
2015-08-31 13:58 ` [PATCH 1/4] perf tools: Add a test for decoding of " Adrian Hunter
2015-09-01 0:18 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-01 8:17 ` Adrian Hunter [this message]
2015-09-01 11:03 ` 平松雅巳 / HIRAMATU，MASAMI
2015-08-31 13:58 ` [PATCH 2/4] x86/insn: perf tools: Pedantically tweak opcode map for MPX instructions Adrian Hunter
2015-08-31 14:48 ` Arnaldo Carvalho de Melo
2015-08-31 13:58 ` [PATCH 3/4] x86/insn: perf tools: Add new SHA instructions Adrian Hunter
2015-08-31 14:50 ` Arnaldo Carvalho de Melo
2015-08-31 18:58 ` Adrian Hunter
2015-09-01 0:08 ` 平松雅巳 / HIRAMATU，MASAMI
2015-08-31 13:58 ` [PATCH 4/4] x86/insn: perf tools: Add new memory instructions Adrian Hunter
2015-08-31 14:43 ` [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions Arnaldo Carvalho de Melo
2015-09-01 8:54 ` Ingo Molnar
2015-09-01 11:38 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-01 12:10 ` Adrian Hunter
2015-09-01 12:55 ` Ingo Molnar
2015-09-01 15:13 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-01 12:16 ` Adrian Hunter
2015-09-01 13:56 ` Arnaldo Carvalho de Melo
2015-09-01 13:59 ` Jiri Olsa
2015-09-01 14:55 ` Arnaldo Carvalho de Melo
2015-09-01 19:57 ` Arnaldo Carvalho de Melo
2015-09-02 5:59 ` Jiri Olsa
2015-09-02 6:41 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-02 7:39 ` Ingo Molnar
2015-09-02 10:27 ` 平松雅巳 / HIRAMATU，MASAMI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E55F1E.6030804@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.