All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools/kwboot.c: Support UART fallback mode
Date: Tue, 1 Sep 2015 14:52:21 +0200	[thread overview]
Message-ID: <55E59F85.40008@denx.de> (raw)
In-Reply-To: <1441052989-14603-1-git-send-email-kevin.smith@elecsyscorp.com>

Hi Kevin,

(Added Luka to Cc, as the Marvell / MVEBU custodian)

On 31.08.2015 22:30, Kevin Smith wrote:
> On some processors such as Armada 38x, if the hardware-
> configured boot mode fails, the CPU falls back to booting over
> UART.  When this happens the chip prints a failure message, waits
> for the magic sequence and, when it is received, prints a
> "(boot)" message, then sends a NAK to start the transfer.
>
> This breaks the current kwboot behavior because the xmodem
> transfer only tries to read one character after the magic
> sequence, looking for the NAK.  Instead it gets the "(boot)"
> text, and retries the magic sequence.  The CPU thinks the
> repeated sequence is part of the packet, stops NAKing, and one
> side or another eventually times out.
>
> This patch adds support for a fallback mode which continues to
> scan for a NAK in the characters received after the sequence,
> printing out any non-NAK characters.  This allows kwboot to skip
> the "(boot)" message, find the NAK, and start the transfer
> successfully.
>
> Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com>

I've not seen this "(boot)" yet. But the patch looks good. So:

Reviewed-by: Stefan Roese <sr@denx.de>

BTW: Please always keep Luka on MVEBU related patches on Cc.

Thanks,
Stefan

  reply	other threads:[~2015-09-01 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 20:30 [U-Boot] [PATCH] tools/kwboot.c: Support UART fallback mode Kevin Smith
2015-09-01 12:52 ` Stefan Roese [this message]
2016-03-24  9:29   ` Stefan Roese
2016-03-29 15:47     ` Kevin Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E59F85.40008@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.