From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 11/23] scsi_dh_alua: Make stpg synchronous
Date: Tue, 1 Sep 2015 14:58:27 +0200 [thread overview]
Message-ID: <55E5A0F3.10009@suse.de> (raw)
In-Reply-To: <20150901100450.GA9838@lst.de>
On 09/01/2015 12:04 PM, Christoph Hellwig wrote:
> On Thu, Aug 27, 2015 at 02:41:09PM +0200, Hannes Reinecke wrote:
>> We should be issuing STPG synchronously as we need to
>> evaluate the return code on failure.
>
> This looks right, but I think the patch needs to be split and needs
> a way better changelog.
>
> patch 1:
> - factor out the alua_stpg helper
>
> patch 2:
> - async STPG
> - please explain that alua_activate will now block and why this is ok
>
> patch 3:
> - add the new call to alua_rtpg and why it's added
>
Okay, will be doing so with the next round.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-01 12:58 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 12:40 [PATCHv4 00/23] asynchronous ALUA device handler Hannes Reinecke
2015-08-27 12:40 ` [PATCH 01/23] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-09-01 9:37 ` Christoph Hellwig
2015-09-04 3:36 ` Martin K. Petersen
2015-09-22 18:28 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 02/23] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-09-04 3:37 ` Martin K. Petersen
2015-09-22 18:29 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 03/23] scsi_dh_alua: improved logging Hannes Reinecke
2015-09-04 3:38 ` Martin K. Petersen
2015-09-22 18:30 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 04/23] scsi_dh_alua: use standard logging functions Hannes Reinecke
2015-09-01 9:48 ` Christoph Hellwig
2015-09-01 12:39 ` Hannes Reinecke
2015-09-22 18:32 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 05/23] scsi_dh_alua: return standard SCSI return codes in submit_rtpg Hannes Reinecke
2015-09-01 9:52 ` Christoph Hellwig
2015-09-22 18:34 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 06/23] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-09-01 9:52 ` Christoph Hellwig
2015-09-04 3:40 ` Martin K. Petersen
2015-09-22 18:36 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 07/23] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-09-04 3:41 ` Martin K. Petersen
2015-09-22 18:36 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 08/23] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-09-04 3:42 ` Martin K. Petersen
2015-09-22 18:37 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 09/23] scsi_dh_alua: use unaligned access macros Hannes Reinecke
2015-09-01 9:53 ` Christoph Hellwig
2015-09-04 3:43 ` Martin K. Petersen
2015-09-22 18:37 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 10/23] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2015-09-01 9:55 ` Christoph Hellwig
2015-09-04 3:44 ` Martin K. Petersen
2015-09-22 18:43 ` Ewan Milne
2015-09-24 16:37 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 11/23] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2015-09-01 10:04 ` Christoph Hellwig
2015-09-01 12:58 ` Hannes Reinecke [this message]
2015-09-22 18:50 ` Ewan Milne
2015-09-24 16:47 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 12/23] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2015-09-01 10:07 ` Christoph Hellwig
2015-09-22 18:54 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 13/23] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2015-09-01 10:20 ` Christoph Hellwig
2015-09-01 13:02 ` Hannes Reinecke
2015-09-01 13:44 ` Christoph Hellwig
2015-09-01 14:01 ` Hannes Reinecke
2015-09-01 10:48 ` Christoph Hellwig
2015-09-22 18:57 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 14/23] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2015-09-22 19:04 ` Ewan Milne
2015-09-24 17:19 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 15/23] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-09-22 19:10 ` Ewan Milne
2015-09-28 6:41 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 16/23] scsi: Add scsi_vpd_lun_id() Hannes Reinecke
2015-09-01 10:22 ` Christoph Hellwig
2015-09-01 12:43 ` Hannes Reinecke
2015-09-22 19:17 ` Ewan Milne
2015-09-28 7:18 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 17/23] scsi_dh_alua: use unique device id Hannes Reinecke
2015-09-01 10:25 ` Christoph Hellwig
2015-09-22 19:31 ` Ewan Milne
2015-09-28 7:41 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 18/23] revert "scsi_dh_alua: ALUA hander attach should succeed while TPG is transitioning" Hannes Reinecke
2015-09-22 19:34 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2015-09-01 11:15 ` Christoph Hellwig
2015-09-01 12:57 ` Hannes Reinecke
2015-09-02 6:39 ` Christoph Hellwig
2015-09-02 8:48 ` Hannes Reinecke
2015-11-05 20:34 ` Todd Gill
2015-09-22 19:49 ` Ewan Milne
2015-09-22 20:15 ` Hannes Reinecke
2015-09-23 13:58 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2015-09-01 10:31 ` Christoph Hellwig
2015-09-22 19:57 ` Ewan Milne
2015-09-23 13:01 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 21/23] scsi_dh_alua: update all port states Hannes Reinecke
2015-09-01 10:32 ` Christoph Hellwig
2015-09-22 20:04 ` Ewan Milne
2015-09-22 20:20 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 22/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2015-09-01 10:34 ` Christoph Hellwig
2015-09-22 20:05 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 23/23] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2015-09-01 10:34 ` Christoph Hellwig
2015-09-22 20:05 ` Ewan Milne
2015-09-24 16:25 ` [PATCHv4 00/23] asynchronous ALUA device handler Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5A0F3.10009@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.