From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWlNr-0005ko-7y for qemu-devel@nongnu.org; Tue, 01 Sep 2015 09:13:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWlNm-000622-EA for qemu-devel@nongnu.org; Tue, 01 Sep 2015 09:13:55 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:6519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWlNl-0005xP-9T for qemu-devel@nongnu.org; Tue, 01 Sep 2015 09:13:50 -0400 Message-ID: <55E5A47E.2090403@huawei.com> Date: Tue, 1 Sep 2015 21:13:34 +0800 From: Gonglei MIME-Version: 1.0 References: <1441101059-14269-1-git-send-email-berrange@redhat.com> In-Reply-To: <1441101059-14269-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Programmingkid , Paolo Bonzini , Markus Armbruster , =?windows-1252?Q?Andreas_F=E4rber?= On 2015/9/1 17:50, Daniel P. Berrange wrote: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. The only unique identifier they would then have is the > QOM object path. > > Allowing device_del to accept an object path ensures all > devices are deletable regardless of whether they have an > ID. > > (qemu) device_add usb-mouse > (qemu) qom-list /machine/peripheral-anon > device[0] (child) > type (string) > (qemu) device_del /machine/peripheral-anon/device[0] > > Although objects require an ID to be provided upfront, > there may be cases where the client would prefer to > use QOM paths when deleting. > > Devices are required to be marked as hotpluggable > otherwise an error is raised > > (qemu) device_del /machine/unattached/device[4] > Device 'PIIX3' does not support hotplugging > > Similarly objects are required to implement the > user-creatable interface > > (qemu) object_del /machine/unattached/device[4] > /machine/unattached/device[4] is not a user-creatable object > > Signed-off-by: Daniel P. Berrange > --- > > Changed in v3: > > - Add type checks to avoid assertion failures if user > supplied path is not of type device or user-creatable > > hmp-commands.hx | 6 ++++-- > qapi-schema.json | 4 ++-- > qdev-monitor.c | 19 ++++++++++++++----- > qmp-commands.hx | 13 +++++++++++-- > qmp.c | 15 ++++++++++++--- > 5 files changed, 43 insertions(+), 14 deletions(-) Reviewed-by: Gonglei Tested-by: Gonglei