From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: Re: [RESEND PATCH 3/7] usb: phy: isp1301: Export I2C module alias information
Date: Tue, 1 Sep 2015 17:29:44 +0200 [thread overview]
Message-ID: <55E5C468.7010507@osg.samsung.com> (raw)
In-Reply-To: <1440484277-32675-4-git-send-email-javier@osg.samsung.com>
Hello Greg and Felipe,
On 08/25/2015 08:31 AM, Javier Martinez Canillas wrote:
> The I2C core always reports the MODALIAS uevent as "i2c:<client name"
> regardless if the driver was matched using the I2C id_table or the
> of_match_table. So the driver needs to export the I2C table and this
> be built into the module or udev won't have the necessary information
> to auto load the correct module when the device is added.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/usb/phy/phy-isp1301.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c
> index 8a55b37d1a02..db68156568e6 100644
> --- a/drivers/usb/phy/phy-isp1301.c
> +++ b/drivers/usb/phy/phy-isp1301.c
> @@ -31,6 +31,7 @@ static const struct i2c_device_id isp1301_id[] = {
> { "isp1301", 0 },
> { }
> };
> +MODULE_DEVICE_TABLE(i2c, isp1301_id);
>
> static struct i2c_client *isp1301_i2c_client;
>
>
Any comments about this patch? The first version
was posted about a month ago and is very trivial.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-09-01 15:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 6:31 [RESEND PATCH 0/7] Export I2C and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-25 6:31 ` Javier Martinez Canillas
2015-08-25 6:31 ` Javier Martinez Canillas
2015-08-25 6:31 ` [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Javier Martinez Canillas
[not found] ` <1440484277-32675-2-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-26 16:55 ` Wolfram Sang
2015-08-26 16:55 ` Wolfram Sang
2015-08-26 18:09 ` Javier Martinez Canillas
[not found] ` <55DE00F6.1070206-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-31 20:31 ` Wolfram Sang
2015-08-31 20:31 ` Wolfram Sang
2015-08-31 22:30 ` Javier Martinez Canillas
[not found] ` <55E4D57E.7050708-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-31 22:46 ` Wolfram Sang
2015-08-31 22:46 ` Wolfram Sang
2015-08-25 6:31 ` [RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information Javier Martinez Canillas
2015-08-25 6:31 ` Javier Martinez Canillas
2015-08-25 7:32 ` Lee Jones
2015-08-25 7:32 ` Lee Jones
2015-08-25 6:31 ` [RESEND PATCH 3/7] usb: phy: isp1301: " Javier Martinez Canillas
2015-09-01 15:29 ` Javier Martinez Canillas [this message]
2015-09-09 23:38 ` Javier Martinez Canillas
2015-08-25 6:31 ` [RESEND PATCH 4/7] ALSA: ppc: keywest: " Javier Martinez Canillas
2015-08-25 10:19 ` Takashi Iwai
2015-08-25 10:19 ` Takashi Iwai
2015-08-25 6:31 ` [RESEND PATCH 5/7] extcon: Export OF module alias information in missing drivers Javier Martinez Canillas
2015-09-03 4:28 ` Chanwoo Choi
2015-08-25 6:31 ` [RESEND PATCH 6/7] leds: " Javier Martinez Canillas
2015-08-25 9:13 ` Jacek Anaszewski
2015-08-25 6:31 ` [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information Javier Martinez Canillas
2015-08-25 16:20 ` Mark Brown
2015-08-25 17:33 ` Javier Martinez Canillas
2015-08-25 18:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5C468.7010507@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.