From: Eric Blake <eblake@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
qemu block <qemu-block@nongnu.org>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child
Date: Tue, 1 Sep 2015 09:34:10 -0600 [thread overview]
Message-ID: <55E5C572.7000606@redhat.com> (raw)
In-Reply-To: <55E4F767.1070602@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On 08/31/2015 06:55 PM, Wen Congyang wrote:
>>> +This command is still a work in progress. It doesn't support all
>>> +block drivers. Stay away from it unless you want it to help with
>>> +its development.
>>
>> Maybe we should name it 'x-child-add' for now, so that we aren't baking
>> ourselves into a corner.
>
> Do you mean the command name should be x-child-add? It is OK.
Use of the 'x-' prefix means a command is experimental and may change or
be withdrawn. It gives us a way to test if an interface is useful
without committing to that interface long term. We've still got time
before 2.5 to get blockdev-add working everywhere, in which case I think
we are better off using blockdev-add to create a new unattached BDS and
then have this command pass the node name to be made the new child,
rather than all the options for opening the child from scratch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-01 15:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 7:51 [Qemu-devel] [Patch for-2.5 v2 0/6] qapi: child add/delete support Wen Congyang
2015-08-11 7:51 ` [Qemu-devel] [Patch for-2.5 v2 1/6] QAPI: move InetSocketAddress to qapi/common.json Wen Congyang
2015-08-31 17:04 ` Eric Blake
2015-08-11 7:51 ` [Qemu-devel] [Patch for-2.5 v2 2/6] support nbd driver in blockdev-add Wen Congyang
2015-08-31 17:19 ` Eric Blake
2015-09-01 9:35 ` Wen Congyang
2015-08-11 7:51 ` [Qemu-devel] [Patch for-2.5 v2 3/6] Add new block driver interface to add/delete a BDS's child Wen Congyang
2015-08-31 17:40 ` Eric Blake
2015-09-01 0:44 ` Wen Congyang
2015-09-01 15:30 ` Eric Blake
2015-09-08 9:10 ` Wen Congyang
2015-09-08 15:52 ` Eric Blake
2015-09-09 6:14 ` Wen Congyang
2015-09-01 3:06 ` Wen Congyang
2015-08-11 7:51 ` [Qemu-devel] [Patch for-2.5 v2 4/6] quorum: implement bdrv_add_child() and bdrv_del_child() Wen Congyang
2015-08-31 18:53 ` Eric Blake
2015-09-01 0:48 ` Wen Congyang
2015-08-11 7:51 ` [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child Wen Congyang
2015-08-31 19:04 ` Eric Blake
2015-09-01 0:55 ` Wen Congyang
2015-09-01 15:34 ` Eric Blake [this message]
2015-09-02 1:25 ` Wen Congyang
2015-09-02 15:00 ` Eric Blake
2015-09-07 3:55 ` Wen Congyang
2015-09-08 15:53 ` Eric Blake
2015-09-01 5:51 ` Wen Congyang
2015-08-11 7:51 ` [Qemu-devel] [Patch for-2.5 v2 6/6] hmp: " Wen Congyang
2015-08-31 1:09 ` Wen Congyang
2015-08-31 7:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5C572.7000606@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.