All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: David Turner <dturner@twopensource.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] path.c: make 'common_list' a file local symbol
Date: Tue, 1 Sep 2015 16:54:09 +0100	[thread overview]
Message-ID: <55E5CA21.5080306@ramsayjones.plus.com> (raw)


Commit 04afda89 ("refs: clean up common_list", 26-08-2015) changed
the type of the 'common_list' symbol from an array of 'formatted'
strings to an array of struct containing the same data. However, in
addition it also (inadvertently) changed the visibility of the
symbol from file local to external.

In order to revert the visibility of the symbol to file local, add
the static modifier to the declaration of 'common_list'.

Noticed by sparse (symbol 'common_list' was not declared. Should it
be static?).

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi David,

If you need to re-roll the patches on your 'dt/refs-bisection' branch, could you
please squash this into the relevant patch.

Thanks!

ATB,
Ramsay Jones

 path.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/path.c b/path.c
index 9d32d19..a80eaf7 100644
--- a/path.c
+++ b/path.c
@@ -100,7 +100,7 @@ struct common_dir {
     const char *dirname;
 };
 
-struct common_dir common_list[] = {
+static struct common_dir common_list[] = {
     { 0, 1, 0, "branches" },
     { 0, 1, 0, "hooks" },
     { 0, 1, 0, "info" },
-- 
2.5.0

             reply	other threads:[~2015-09-01 16:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 15:54 Ramsay Jones [this message]
2015-09-01 18:06 ` [PATCH] path.c: make 'common_list' a file local symbol Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E5CA21.5080306@ramsayjones.plus.com \
    --to=ramsay@ramsayjones.plus.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.