All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh.shilimkar@oracle.com (santosh.shilimkar at oracle.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: keystone: use one to one address translations under netcp
Date: Tue, 01 Sep 2015 14:19:20 -0700	[thread overview]
Message-ID: <55E61658.9010207@oracle.com> (raw)
In-Reply-To: <1441139324-29296-1-git-send-email-w-kwok2@ti.com>

On 9/1/15 1:28 PM, WingMan Kwok wrote:
> Network subsystem NetCP in Keystone-2 devices includes some HW blocks
> that are memory mapped to ranges outside that of the NetCP itself.
> Thus address space of a child node of the NetCP node needs to be
> mapped 1:1 onto the parent address space.  Hence empty ranges
> should be used under the NetCP node.
>
> Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
> ---
>   arch/arm/boot/dts/k2e-netcp.dtsi  |    8 +++-----
>   arch/arm/boot/dts/k2hk-netcp.dtsi |   14 ++++++--------
>   arch/arm/boot/dts/k2l-netcp.dtsi  |    8 +++-----
>   3 files changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/k2e-netcp.dtsi b/arch/arm/boot/dts/k2e-netcp.dtsi
> index b13b3c9..e103ed9 100644
> --- a/arch/arm/boot/dts/k2e-netcp.dtsi
> +++ b/arch/arm/boot/dts/k2e-netcp.dtsi
> @@ -111,9 +111,7 @@ netcp: netcp at 24000000 {
>   	compatible = "ti,netcp-1.0";
>   	#address-cells = <1>;
>   	#size-cells = <1>;
> -
> -	/* NetCP address range */
> -	ranges = <0 0x24000000 0x1000000>;
> +	ranges;
>
What blocks are we talking here. We need to increase the
range if the current range isn't covering entire NETCP
address space. Removing range isn't a solution.

Regards,
Santosh

WARNING: multiple messages have this Message-ID (diff)
From: "santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org" <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: WingMan Kwok <w-kwok2-l0cyMroinI0@public.gmane.org>,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: m-karicheri2-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH] ARM: dts: keystone: use one to one address translations under netcp
Date: Tue, 01 Sep 2015 14:19:20 -0700	[thread overview]
Message-ID: <55E61658.9010207@oracle.com> (raw)
In-Reply-To: <1441139324-29296-1-git-send-email-w-kwok2-l0cyMroinI0@public.gmane.org>

On 9/1/15 1:28 PM, WingMan Kwok wrote:
> Network subsystem NetCP in Keystone-2 devices includes some HW blocks
> that are memory mapped to ranges outside that of the NetCP itself.
> Thus address space of a child node of the NetCP node needs to be
> mapped 1:1 onto the parent address space.  Hence empty ranges
> should be used under the NetCP node.
>
> Signed-off-by: WingMan Kwok <w-kwok2-l0cyMroinI0@public.gmane.org>
> ---
>   arch/arm/boot/dts/k2e-netcp.dtsi  |    8 +++-----
>   arch/arm/boot/dts/k2hk-netcp.dtsi |   14 ++++++--------
>   arch/arm/boot/dts/k2l-netcp.dtsi  |    8 +++-----
>   3 files changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/k2e-netcp.dtsi b/arch/arm/boot/dts/k2e-netcp.dtsi
> index b13b3c9..e103ed9 100644
> --- a/arch/arm/boot/dts/k2e-netcp.dtsi
> +++ b/arch/arm/boot/dts/k2e-netcp.dtsi
> @@ -111,9 +111,7 @@ netcp: netcp@24000000 {
>   	compatible = "ti,netcp-1.0";
>   	#address-cells = <1>;
>   	#size-cells = <1>;
> -
> -	/* NetCP address range */
> -	ranges = <0 0x24000000 0x1000000>;
> +	ranges;
>
What blocks are we talking here. We need to increase the
range if the current range isn't covering entire NETCP
address space. Removing range isn't a solution.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: WingMan Kwok <w-kwok2@ti.com>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, ssantosh@kernel.org
Cc: m-karicheri2@ti.com
Subject: Re: [PATCH] ARM: dts: keystone: use one to one address translations under netcp
Date: Tue, 01 Sep 2015 14:19:20 -0700	[thread overview]
Message-ID: <55E61658.9010207@oracle.com> (raw)
In-Reply-To: <1441139324-29296-1-git-send-email-w-kwok2@ti.com>

On 9/1/15 1:28 PM, WingMan Kwok wrote:
> Network subsystem NetCP in Keystone-2 devices includes some HW blocks
> that are memory mapped to ranges outside that of the NetCP itself.
> Thus address space of a child node of the NetCP node needs to be
> mapped 1:1 onto the parent address space.  Hence empty ranges
> should be used under the NetCP node.
>
> Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
> ---
>   arch/arm/boot/dts/k2e-netcp.dtsi  |    8 +++-----
>   arch/arm/boot/dts/k2hk-netcp.dtsi |   14 ++++++--------
>   arch/arm/boot/dts/k2l-netcp.dtsi  |    8 +++-----
>   3 files changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/k2e-netcp.dtsi b/arch/arm/boot/dts/k2e-netcp.dtsi
> index b13b3c9..e103ed9 100644
> --- a/arch/arm/boot/dts/k2e-netcp.dtsi
> +++ b/arch/arm/boot/dts/k2e-netcp.dtsi
> @@ -111,9 +111,7 @@ netcp: netcp@24000000 {
>   	compatible = "ti,netcp-1.0";
>   	#address-cells = <1>;
>   	#size-cells = <1>;
> -
> -	/* NetCP address range */
> -	ranges = <0 0x24000000 0x1000000>;
> +	ranges;
>
What blocks are we talking here. We need to increase the
range if the current range isn't covering entire NETCP
address space. Removing range isn't a solution.

Regards,
Santosh


  reply	other threads:[~2015-09-01 21:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 20:28 [PATCH] ARM: dts: keystone: use one to one address translations under netcp WingMan Kwok
2015-09-01 20:28 ` WingMan Kwok
2015-09-01 20:28 ` WingMan Kwok
2015-09-01 21:19 ` santosh.shilimkar at oracle.com [this message]
2015-09-01 21:19   ` santosh.shilimkar
2015-09-01 21:19   ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-02 15:31   ` Kwok, WingMan
2015-09-02 15:31     ` Kwok, WingMan
2015-09-02 15:31     ` Kwok, WingMan
2015-09-02 15:50     ` santosh shilimkar
2015-09-02 15:50       ` santosh shilimkar
2015-09-02 16:35       ` Murali Karicheri
2015-09-02 16:35         ` Murali Karicheri
2015-09-02 16:35         ` Murali Karicheri
2015-09-02 17:24         ` santosh shilimkar
2015-09-02 17:24           ` santosh shilimkar
2015-09-02 17:58           ` Murali Karicheri
2015-09-02 17:58             ` Murali Karicheri
2015-09-02 17:58             ` Murali Karicheri
2015-09-02 18:25             ` santosh shilimkar
2015-09-02 18:25               ` santosh shilimkar
2015-09-02 18:25               ` santosh shilimkar
2015-09-02 18:42               ` Murali Karicheri
2015-09-02 18:42                 ` Murali Karicheri
2015-09-03 14:26       ` Tony Lindgren
2015-09-03 14:26         ` Tony Lindgren
2015-09-03 14:26         ` Tony Lindgren
2015-09-03 14:48         ` santosh.shilimkar at oracle.com
2015-09-03 14:48           ` santosh.shilimkar
2015-09-03 19:18         ` Murali Karicheri
2015-09-03 19:18           ` Murali Karicheri
2015-09-03 19:18           ` Murali Karicheri
2015-09-08 15:13           ` Tony Lindgren
2015-09-08 15:13             ` Tony Lindgren
2015-09-08 15:13             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E61658.9010207@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.