From: Jiang Liu <jiang.liu@linux.intel.com>
To: Huang Shijie <shijie.huang@arm.com>, tglx@linutronix.de
Cc: peterz@infradead.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu
Date: Wed, 2 Sep 2015 10:29:22 +0800 [thread overview]
Message-ID: <55E65F02.3010203@linux.intel.com> (raw)
In-Reply-To: <1441160695-19809-1-git-send-email-shijie.huang@arm.com>
On 2015/9/2 10:24, Huang Shijie wrote:
> Actually, we always use the first irq action of the @desc->action chain,
> this patch remove the second parameter from handle_irq_event_percpu() which
> makes the code more tidy.
>
> Signed-off-by: Huang Shijie <shijie.huang@arm.com>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> kernel/irq/chip.c | 2 +-
> kernel/irq/handle.c | 7 +++----
> kernel/irq/internals.h | 2 +-
> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index 6e40a95..27e4833 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -680,7 +680,7 @@ handle_percpu_irq(unsigned int irq, struct irq_desc *desc)
> if (chip->irq_ack)
> chip->irq_ack(&desc->irq_data);
>
> - handle_irq_event_percpu(desc, desc->action);
> + handle_irq_event_percpu(desc);
>
> if (chip->irq_eoi)
> chip->irq_eoi(&desc->irq_data);
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index b6eeea8..bc2f892 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -130,11 +130,11 @@ void __irq_wake_thread(struct irq_desc *desc, struct irqaction *action)
> wake_up_process(action->thread);
> }
>
> -irqreturn_t
> -handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
> +irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
> {
> irqreturn_t retval = IRQ_NONE;
> unsigned int flags = 0, irq = desc->irq_data.irq;
> + struct irqaction *action = desc->action;
>
> do {
> irqreturn_t res;
> @@ -182,14 +182,13 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
>
> irqreturn_t handle_irq_event(struct irq_desc *desc)
> {
> - struct irqaction *action = desc->action;
> irqreturn_t ret;
>
> desc->istate &= ~IRQS_PENDING;
> irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
> raw_spin_unlock(&desc->lock);
>
> - ret = handle_irq_event_percpu(desc, action);
> + ret = handle_irq_event_percpu(desc);
>
> raw_spin_lock(&desc->lock);
> irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS);
> diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
> index eee4b38..1be888c 100644
> --- a/kernel/irq/internals.h
> +++ b/kernel/irq/internals.h
> @@ -81,7 +81,7 @@ extern void irq_mark_irq(unsigned int irq);
>
> extern void init_kstat_irqs(struct irq_desc *desc, int node, int nr);
>
> -irqreturn_t handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action);
> +irqreturn_t handle_irq_event_percpu(struct irq_desc *desc);
> irqreturn_t handle_irq_event(struct irq_desc *desc);
>
> /* Resending of interrupts :*/
>
next prev parent reply other threads:[~2015-09-02 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 2:24 [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu Huang Shijie
2015-09-02 2:29 ` Jiang Liu [this message]
2015-09-22 14:18 ` [tip:irq/core] genirq: Remove the second parameter from handle_irq_event_percpu() tip-bot for Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E65F02.3010203@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=peterz@infradead.org \
--cc=shijie.huang@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.