From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Date: Wed, 02 Sep 2015 08:35:24 +0000 Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register Message-Id: <55E6B4CC.3040502@redhat.com> List-Id: References: <1441143678-14295-1-git-send-email-thuth@redhat.com> <1441146305.2668.51.camel@au1.ibm.com> <20150901224521.GC23007@fergus.ozlabs.ibm.com> <1441148107.2668.57.camel@au1.ibm.com> <55E6A48D.5070800@redhat.com> <334DA903-4793-45C4-9FCB-D9B022DE74A2@suse.de> In-Reply-To: <334DA903-4793-45C4-9FCB-D9B022DE74A2@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: "benh@au1.ibm.com" , Paul Mackerras , "kvm-ppc@vger.kernel.org" , Alexander Graf , "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" , Andrew Jones On 02/09/15 10:26, Alexander Graf wrote: > >> Am 02.09.2015 um 09:26 schrieb Thomas Huth : >> >>> On 02/09/15 00:55, Benjamin Herrenschmidt wrote: >>>> On Wed, 2015-09-02 at 08:45 +1000, Paul Mackerras wrote: >>>> On Wed, Sep 02, 2015 at 08:25:05AM +1000, Benjamin Herrenschmidt >>>> wrote: >>>>> On Tue, 2015-09-01 at 23:41 +0200, Thomas Huth wrote: >>>>>> The size of the Problem State Priority Boost Register is only >>>>>> 32 bits, so let's change the type of the corresponding variable >>>>>> accordingly to avoid future trouble. >>>>> >>>>> It's not future trouble, it's broken today for LE and this should >>>>> fix >>>>> it BUT .... >>>> >>>> No, it's broken today for BE hosts, which will always see 0 for the >>>> PSPB register value. LE hosts are fine. >> >> Right ... I just meant that nobody really experienced trouble with this >> today yet, but the bug is already present now already of course. > > Sounds like a great candidate for kvm-unit-tests then, no? ;) I'm certainly looking forward to seeing powerpc support in there :-) Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4544A1A1E25 for ; Wed, 2 Sep 2015 18:35:32 +1000 (AEST) Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register To: Alexander Graf References: <1441143678-14295-1-git-send-email-thuth@redhat.com> <1441146305.2668.51.camel@au1.ibm.com> <20150901224521.GC23007@fergus.ozlabs.ibm.com> <1441148107.2668.57.camel@au1.ibm.com> <55E6A48D.5070800@redhat.com> <334DA903-4793-45C4-9FCB-D9B022DE74A2@suse.de> Cc: "benh@au1.ibm.com" , Paul Mackerras , "kvm-ppc@vger.kernel.org" , Alexander Graf , "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" , Andrew Jones From: Thomas Huth Message-ID: <55E6B4CC.3040502@redhat.com> Date: Wed, 2 Sep 2015 10:35:24 +0200 MIME-Version: 1.0 In-Reply-To: <334DA903-4793-45C4-9FCB-D9B022DE74A2@suse.de> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 02/09/15 10:26, Alexander Graf wrote: > >> Am 02.09.2015 um 09:26 schrieb Thomas Huth : >> >>> On 02/09/15 00:55, Benjamin Herrenschmidt wrote: >>>> On Wed, 2015-09-02 at 08:45 +1000, Paul Mackerras wrote: >>>> On Wed, Sep 02, 2015 at 08:25:05AM +1000, Benjamin Herrenschmidt >>>> wrote: >>>>> On Tue, 2015-09-01 at 23:41 +0200, Thomas Huth wrote: >>>>>> The size of the Problem State Priority Boost Register is only >>>>>> 32 bits, so let's change the type of the corresponding variable >>>>>> accordingly to avoid future trouble. >>>>> >>>>> It's not future trouble, it's broken today for LE and this should >>>>> fix >>>>> it BUT .... >>>> >>>> No, it's broken today for BE hosts, which will always see 0 for the >>>> PSPB register value. LE hosts are fine. >> >> Right ... I just meant that nobody really experienced trouble with this >> today yet, but the bug is already present now already of course. > > Sounds like a great candidate for kvm-unit-tests then, no? ;) I'm certainly looking forward to seeing powerpc support in there :-) Thomas