From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Programmingkid <programmingkidx@gmail.com>,
Gonglei <arei.gonglei@huawei.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths
Date: Wed, 2 Sep 2015 11:40:23 +0200 [thread overview]
Message-ID: <55E6C407.6030708@redhat.com> (raw)
In-Reply-To: <1441101059-14269-1-git-send-email-berrange@redhat.com>
On 01/09/2015 11:50, Daniel P. Berrange wrote:
> Similarly objects are required to implement the
> user-creatable interface
>
> (qemu) object_del /machine/unattached/device[4]
> /machine/unattached/device[4] is not a user-creatable object
The question is not whether it's user-creatable, but whether it's
user-created. It would probably be bad to delete the iothread that
x-data-plane=on creates.
IIRC the id is mandatory for all of object_add (HMP), object-add (QMP)
and -object, so I would do without the change to object_del.
Paolo
prev parent reply other threads:[~2015-09-02 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 9:50 [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths Daniel P. Berrange
2015-09-01 13:13 ` Gonglei
2015-09-01 13:17 ` Andreas Färber
2015-09-01 13:23 ` Daniel P. Berrange
2015-09-01 15:55 ` Eric Blake
2015-09-01 15:58 ` Programmingkid
2015-09-01 16:00 ` Andreas Färber
2015-09-01 15:57 ` Eric Blake
2015-09-02 9:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E6C407.6030708@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.