All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: "Dāvis Mosāns" <davispuh@gmail.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free
Date: Wed, 2 Sep 2015 14:08:19 +0200	[thread overview]
Message-ID: <55E6E6B3.5070900@redhat.com> (raw)
In-Reply-To: <1440131362-18605-1-git-send-email-davispuh@gmail.com>

On 21.8.2015 06:29, Dāvis Mosāns wrote:
> When pci_pool_alloc fails in mvs_task_prep then task->lldd_task stays
> NULL but it's later used in mvs_abort_task as slot which is passed
> to mvs_slot_task_free causing NULL pointer dereference.
>
> Just return from mvs_slot_task_free when passed with NULL slot.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=101891
> Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Cheers,
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-02 12:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21  4:29 [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free Dāvis Mosāns
2015-09-01 20:08 ` Dāvis Mosāns
2015-09-02 12:08 ` Tomas Henzl [this message]
2015-10-20 17:41 ` Dāvis Mosāns
2015-10-21  7:33   ` Johannes Thumshirn
2015-10-21 13:18     ` Dāvis Mosāns
2015-10-21 13:18       ` Dāvis Mosāns
2015-10-21 13:47       ` Johannes Thumshirn
2015-10-21 13:47         ` Johannes Thumshirn
2015-10-21 14:26         ` Dāvis Mosāns
2015-10-21 14:29           ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E6E6B3.5070900@redhat.com \
    --to=thenzl@redhat.com \
    --cc=JBottomley@odin.com \
    --cc=davispuh@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.