Re: [Qemu-devel] [PATCH v3 1/2] virtio dataplane: adapt dataplane for virtio Version 1

[Pierre Morel <pmorel@linux.vnet.ibm.com>]

On 09/02/2015 05:59 PM, Eric Blake wrote:
> [meta-comment]
>
> On 09/02/2015 09:12 AM, Pierre Morel wrote:
>> Let dataplane allocate different region for the desc/avail/used
>> ring regions.
>> Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail
>> rings accordingly.
> This part is fine.
>
>> Changes from V2:
>> - incorporate the code directly in vring_setup().
>> - added room for the event indexes used with VIRTIO_RING_F_EVENT_IDX
>>
>> Changes from v1:
>> - use a macro to gain LOCs inside of vring_setup()
> But the above changelog text belongs better...
>
>> Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
>> ---
> ...here after the '---' separator, where it will be stripped by 'git
> am'.  It is useful for reviewers of the earlier versions, but in the
> long run, when reading 'git log', we will only care about what got
> committed, not how many tries it took to get to that point.
>
Thanks.
I do the right thing immediately.