From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] init-install-efi.sh: Avoid /mnt/mtab creation if already present
Date: Wed, 02 Sep 2015 14:19:21 -0500 [thread overview]
Message-ID: <55E74BB9.9040102@linux.intel.com> (raw)
In-Reply-To: <1438614064-10290-1-git-send-email-leonardo.sandoval.gonzalez@linux.intel.com>
ping..
This patch has not been merged and I believe the reason is that I did
not label it as V2 (my fault). Instead, V1 [1] was merged (which is
fine, it gives some message to the user).
[1]
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=445c49ce5007eb0c0aa14680c41b79e7764d8882
On 08/03/2015 10:01 AM, leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> The base-files recipe installs /mnt/mtab (it is a softlink of /proc/mounts),
> so if an image includes the latter, there is no new to created it again inside
> the install-efi.sh script, otherwise an error may occur as indicated on the
> bug's site.
>
> [YOCTO #7971]
>
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> ---
> meta/recipes-core/initrdscripts/files/init-install-efi.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/initrdscripts/files/init-install-efi.sh b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> index f339b30..665d04a 100644
> --- a/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> +++ b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> @@ -109,7 +109,11 @@ rm -f /etc/udev/scripts/mount*
> umount ${device}* 2> /dev/null || /bin/true
>
> mkdir -p /tmp
> -cat /proc/mounts > /etc/mtab
> +
> +# Create /etc/mtab if not present
> +if [ ! -e /etc/mtab ]; then
> + cat /proc/mounts > /etc/mtab
> +fi
>
> disk_size=$(parted ${device} unit mb print | grep Disk | cut -d" " -f 3 | sed -e "s/MB//")
>
>
prev parent reply other threads:[~2015-09-02 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 15:01 [PATCH] init-install-efi.sh: Avoid /mnt/mtab creation if already present leonardo.sandoval.gonzalez
2015-08-21 20:02 ` Benjamin Esquivel
2015-08-25 14:25 ` Leonardo Sandoval
2015-09-02 19:19 ` Leonardo Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E74BB9.9040102@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.