From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH net-next] net: Support ip route get via given table
Date: Wed, 2 Sep 2015 13:22:32 -0600
Message-ID: <55E74C78.8000409@cumulusnetworks.com>
References: <1441220592-7339-1-git-send-email-dsa@cumulusnetworks.com>
 <20150902191244.GE20527@pox.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Thomas Graf <tgraf@suug.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f182.google.com ([209.85.223.182]:34832 "EHLO
	mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755596AbbIBTWf (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 2 Sep 2015 15:22:35 -0400
Received: by ioiz6 with SMTP id z6so32299965ioi.2
        for <netdev@vger.kernel.org>; Wed, 02 Sep 2015 12:22:35 -0700 (PDT)
In-Reply-To: <20150902191244.GE20527@pox.localdomain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 9/2/15 1:12 PM, Thomas Graf wrote:
> On 09/02/15 at 12:03pm, David Ahern wrote:
>> Add support for 'ip [-6] route get table X' where the user wants to
>> force the FIB lookup from a given table.
>>
>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>
> Will you use this outside of 'ip route get' as well? If so, how? I'm
> asking because you propose to add the check and new behaviour to bypass
> the routing rules to the routing fastpath, wouldn't it be better to
> handle this in inet_rtm_getroute()?
>

The way IPv6 code is structured it seemed more appropriate to pass in a 
table id as part of the flow. I made IPv4 consistent with that approach.