From: David Ahern <dsa@cumulusnetworks.com>
To: Alexander Duyck <alexander.duyck@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: Add table id from route lookup to route response
Date: Wed, 2 Sep 2015 14:47:08 -0600 [thread overview]
Message-ID: <55E7604C.8070603@cumulusnetworks.com> (raw)
In-Reply-To: <55E75EE4.2050602@gmail.com>
On 9/2/15 2:41 PM, Alexander Duyck wrote:
>
> Why not implement this this same for IPv4 and IPv6? It looks like it is
> only included if it is non-zer and not MAIN in the above case, and then
> below as long as a table ID is non-zero you are setting the value. Why
> not just include the value in all cases where it is defined just like
> for IPv6?
>
I like Thomas' suggestion to add an rtm_flag better. We only need to fix
IPv4 which hardcodes the tableid. Adding a flag, e.g.,
+#define RTM_F_LOOKUP_TABLE 0x1000 /* set rtm_table to FIB lookup
result */
signifies the caller wants the real table. When set rt_fill_info sets
rtm_table to the actual table id. This allows updated tools to work
properly for both ipv4 and ipv6 and without breaking existing userspace.
next prev parent reply other threads:[~2015-09-02 20:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 16:40 [PATCH net-next 1/3] net: Refactor rtable initialization David Ahern
2015-09-02 16:40 ` [PATCH net-next 2/3] net: Add FIB table id to rtable David Ahern
2015-09-02 16:40 ` [PATCH net-next 3/3] net: Add table id from route lookup to route response David Ahern
2015-09-02 18:43 ` Thomas Graf
2015-09-02 18:49 ` David Miller
2015-09-02 18:51 ` David Ahern
2015-09-02 19:08 ` Thomas Graf
2015-09-02 19:43 ` Andy Gospodarek
2015-09-02 20:18 ` Thomas Graf
2015-09-02 22:33 ` David Miller
2015-09-02 20:16 ` [PATCH net-next v2] " David Ahern
2015-09-02 20:23 ` Thomas Graf
2015-09-02 20:34 ` David Ahern
2015-09-02 20:41 ` Alexander Duyck
2015-09-02 20:47 ` David Ahern [this message]
2015-09-02 20:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E7604C.8070603@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=alexander.duyck@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.