From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33701)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZXVYk-00075Y-3Q
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:32:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZXVYg-0006UJ-2e
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:32:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46413)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZXVYf-0006U6-Ui
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:32:10 -0400
References: <1440780366-7177-1-git-send-email-armbru@redhat.com>
	<1441274118-13702-1-git-send-email-armbru@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55E859E8.9030907@redhat.com>
Date: Thu, 3 Sep 2015 08:32:08 -0600
MIME-Version: 1.0
In-Reply-To: <1441274118-13702-1-git-send-email-armbru@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="VxjR97RJC1KIdf66fc6xFtBW6EoeKCumV"
Subject: Re: [Qemu-devel] [PATCH 32/33] docs/qapi-code-gen.txt: Fix QAPI
	schema examples
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--VxjR97RJC1KIdf66fc6xFtBW6EoeKCumV
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/03/2015 03:55 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/qapi-code-gen.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20

> =20
> - { 'enum': 'BlockdevDriver', 'data': [ 'raw', 'qcow2' ] }
> + { 'enum': 'BlockdevDriver', 'data': [ 'file', 'qcow2' ] }

Done to match actual usage.

>   { 'struct': 'BlockdevCommonOptions',
>     'data': { 'driver': 'BlockdevDriver', 'readonly': 'bool' } }
>   { 'union': 'BlockdevOptions',
> @@ -350,7 +349,7 @@ is identical on the wire to:
>   { 'struct': 'Base', 'data': { 'type': 'Enum' } }
>   { 'struct': 'Branch1', 'data': { 'data': 'str' } }
>   { 'struct': 'Branch2', 'data': { 'data': 'int' } }
> - { 'union': 'Flat': 'base': 'Base', 'discriminator': 'type',
> + { 'union': 'Flat', 'base': 'Base', 'discriminator': 'type',

and done to fix a blatant type of : instead of ,

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--VxjR97RJC1KIdf66fc6xFtBW6EoeKCumV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV6FnoAAoJEKeha0olJ0NqsYoIAIGXkjwfo6O0jwIBIPaOs1VD
1qe+8wU+dHQ9Qg4d3Yh/d4T87Drx6eAvRYIjkp4DBo+rXCw5kxVMx8rOjadqSJRm
MVPV+TAtH2zjp8IH5CLLYGSBooeEoZhNMWPaVV853HCCdALj5N7UntnKsS/q1yIY
gbTwG7TUXT4ZhfsBC+YVuvfPb6NgLEFS/+RJSELjUC1mhdm+HSo92HV3s+gWLDkY
WlgXclsVZIvLT+naTqk4Vg+jQTYhV0wbQtgw+uYBztRuXQ3CyjVfmiAvMV2FfSrE
AOEfKh7o39XkvFqsRiRToVyAhaFduZ8CdnC8RtEwbKflvGx3ucoryNYh8q2/T4Y=
=mT79
-----END PGP SIGNATURE-----

--VxjR97RJC1KIdf66fc6xFtBW6EoeKCumV--