From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 33/33] qapi: Generators crash when --output-dir isn't given, fix
Date: Thu, 3 Sep 2015 08:32:40 -0600 [thread overview]
Message-ID: <55E85A08.7040803@redhat.com> (raw)
In-Reply-To: <1441274118-13702-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
On 09/03/2015 03:55 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-09-03 14:32 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 16:45 [Qemu-devel] [PATCH v2 00/26] qapi: Another round of fixes and cleanups Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 01/26] qapi: Clarify docs on including the same file multiple times Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 02/26] qapi: Clean up cgen() and mcgen() Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 03/26] qapi: Simplify guardname() Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 04/26] qapi-event: Clean up how name of enum QAPIEvent is made Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 05/26] qapi: Reject -p arguments that break qapi-event.py Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 06/26] qapi: Drop unused and useless parameters and variables Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 07/26] qapi: Fix generated code when flat union has member 'kind' Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 08/26] qapi: Generate a nicer struct for flat unions Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 09/26] qapi-visit: Fix generated code when schema has forward refs Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 10/26] qapi-visit: Replace list implicit_structs by set Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 11/26] qapi-visit: Fix two name arguments passed to visitors Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 12/26] tests/qapi-schema: Document alternate's enum lacks visit function Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 13/26] tests/qapi-schema: Document events with base don't work Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 14/26] qapi: Document that input visitor semantics are prone to leaks Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 15/26] qapi: Document shortcoming with union 'data' branch Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 16/26] qapi: Document flaws in checking of names Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 17/26] tests/qapi-schema: Restore test case for flat union base bug Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 18/26] tests/qapi-schema: Rename tests from data- to args- Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 19/26] qapi-tests: New tests for union, alternate command arguments Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 20/26] qapi: Fix to reject union command and event arguments Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 21/26] qapi: Command returning anonymous type doesn't work, outlaw Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err' Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 23/26] qapi-commands: Inline gen_marshal_output_call() Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 25/26] qapi-commands: Drop useless initialization Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 26/26] qapi: Generated code cleanup Markus Armbruster
2015-08-31 15:55 ` [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks Markus Armbruster
2015-08-31 16:05 ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 28/31] tests/qapi-schema: Cover two more syntax errors Markus Armbruster
2015-08-31 16:09 ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members Markus Armbruster
2015-08-31 16:13 ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 30/31] qapi: Fix errors for " Markus Armbruster
2015-08-31 16:19 ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 31/31] qapi: Simplify error reporting for array types Markus Armbruster
2015-08-31 16:28 ` Eric Blake
2015-08-31 16:28 ` [Qemu-devel] [PATCH v2 00/26] qapi: Another round of fixes and cleanups Markus Armbruster
2015-09-03 9:59 ` Markus Armbruster
2015-09-03 9:55 ` [Qemu-devel] [PATCH 32/33] docs/qapi-code-gen.txt: Fix QAPI schema examples Markus Armbruster
2015-09-03 14:32 ` Eric Blake
2015-09-03 9:55 ` [Qemu-devel] [PATCH 33/33] qapi: Generators crash when --output-dir isn't given, fix Markus Armbruster
2015-09-03 14:32 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E85A08.7040803@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.