From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5
Date: Thu, 3 Sep 2015 18:47:18 +0200 [thread overview]
Message-ID: <55E87996.10105@mind.be> (raw)
In-Reply-To: <20150903180200.1bef81ef@free-electrons.com>
On 03-09-15 18:02, Thomas Petazzoni wrote:
> Arnout,
>
> On Wed, 2 Sep 2015 23:12:31 +0200, Arnout Vandecappelle wrote:
>
>> However, I think it would be better to take a different approach here, because
>> there will be more packages with this requirement (we already have libmbim now,
>> but there are probably more that we haven't detected yet because we don't have
>> systemd in the autobuilders).
>>
>> So I think there should be either a new virtual package or a suboption of udev
>> to handle the libgudev case.
>
> The problem is you make a virtual package is that then you must use a
> "depends on": you cannot "select" a virtual package, at least if you
> use the normal virtual package mechanism and Config.in description.
Right. So a suboption of udev then. Any package that needs libgudev also needs
udev, obviously. Something like:
udev/Config.in:
config BR2_PACKAGE_HAS_UDEV
bool
if BR2_PACKAGE_HAS_UDEV
config BR2_PACKAGE_PROVIDES_UDEV
string
config BR2_PACKAGE_NEEDS_GUDEV
bool
config BR2_PACKAGE_PROVIDES_GUDEV
string
endif
systemd/Config.in:
config BR2_PACKAGE_SYSTEMD
# systemd provides udev but not libgudev
select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_NEEDS_GUDEV
eudev/Config.in:
if BR2_PACKAGE_EUDEV
config BR2_PACKAGE_PROVIDES_GUDEV
string
default "eudev"
endif
(Actually, for eudev nothing is needed)
libgudev/Config.in:
if BR2_PACKAGE_LIBGUDEV
config BR2_PACKAGE_PROVIDES_GUDEV
string
default "libgudev"
endif
udisks/Config.in:
config BR2_PACKAGE_UDISKS
select BR2_PACKAGE_NEEDS_GUDEV
udev/udev.mk:
ifeq ($(BR2_PACKAGE_NEEDS_GUDEV),y)
UDEV_DEPENDENCIES += $(call qstrip,$(BR2_PACKAGE_PROVIDES_GUDEV))
endif
udisks already depends on udev so libgudev will be implied if necessary
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2015-09-03 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 14:21 [Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
2015-09-02 14:21 ` [Buildroot] [PATCHv4 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
2015-09-07 21:46 ` Peter Korsgaard
2015-09-02 21:12 ` [Buildroot] [PATCHv4 1/2] udisks: bump to version 1.0.5 Arnout Vandecappelle
2015-09-03 16:02 ` Thomas Petazzoni
2015-09-03 16:47 ` Arnout Vandecappelle [this message]
2015-09-05 17:02 ` Peter Korsgaard
2015-09-07 8:01 ` Vicente Olivert Riera
2015-09-07 8:19 ` Peter Korsgaard
2015-09-07 21:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E87996.10105@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.