Re: [patch net] switchdev: fix return value of switchdev_port_fdb_dump in case of error

["Samudrala, Sridhar" <sridhar.samudrala@intel.com>]

On 9/3/2015 5:04 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is
> idx, so we cannot return errval.
>
> Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

> ---
>   net/switchdev/switchdev.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index 16c1c43..fda38f8 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
>   		.cb = cb,
>   		.idx = idx,
>   	};
> -	int err;
> -
> -	err = switchdev_port_obj_dump(dev, &dump.obj);
> -	if (err)
> -		return err;
>   
> +	switchdev_port_obj_dump(dev, &dump.obj);
>   	return dump.idx;
>   }
>   EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump);