From: Timur Tabi <timur@tabi.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Jakub Kicinski <moorray3@wp.pl>,
GregKH <gregkh@linuxfoundation.org>,
"nareshgbhat@gmail.com" <nareshgbhat@gmail.com>,
"mlangsdo@redhat.com" <mlangsdo@redhat.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"rmk+kernel@arm.linux.org.uk" <rmk+kernel@arm.linux.org.uk>,
Jiri Slaby <jslaby@suse.cz>, Dave P Martin <Dave.Martin@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 05/11] drivers: PL011: refactor pl011_probe()
Date: Thu, 03 Sep 2015 13:09:40 -0500 [thread overview]
Message-ID: <55E88CE4.7080401@tabi.org> (raw)
In-Reply-To: <55E87B3E.8070106@arm.com>
On 09/03/2015 11:54 AM, Andre Przywara wrote:
> I don't get where pl011_early_write() would need any kind of PL011 struct.
> It only references structures defined in the serial core, so it's
> completely dumb MMIO writes and reads, using only the base address
> provided on the command line.
> Are you by any chance mixing up early console and the normal console? To
> me it looks like early console just uses the three tiny functions
> defined just before the declaration and it does not touch vendor at all,
> isn't it?
>
> As for the broken part, any chance you were testing -next, which has
> some patches that broke early console, as we learned today?[1]
I have to apologize -- I forgot that I applied an internal patch that
modified this code, and the bug is in that patch, not yours. Your code
is fine as is.
WARNING: multiple messages have this Message-ID (diff)
From: timur@tabi.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 05/11] drivers: PL011: refactor pl011_probe()
Date: Thu, 03 Sep 2015 13:09:40 -0500 [thread overview]
Message-ID: <55E88CE4.7080401@tabi.org> (raw)
In-Reply-To: <55E87B3E.8070106@arm.com>
On 09/03/2015 11:54 AM, Andre Przywara wrote:
> I don't get where pl011_early_write() would need any kind of PL011 struct.
> It only references structures defined in the serial core, so it's
> completely dumb MMIO writes and reads, using only the base address
> provided on the command line.
> Are you by any chance mixing up early console and the normal console? To
> me it looks like early console just uses the three tiny functions
> defined just before the declaration and it does not touch vendor at all,
> isn't it?
>
> As for the broken part, any chance you were testing -next, which has
> some patches that broke early console, as we learned today?[1]
I have to apologize -- I forgot that I applied an internal patch that
modified this code, and the bug is in that patch, not yours. Your code
is fine as is.
next prev parent reply other threads:[~2015-09-03 18:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 16:26 [PATCH v5 00/11] drivers: PL011: add ARM SBSA Generic UART support Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 01/11] drivers: PL011: avoid potential unregister_driver call Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 02/11] drivers: PL011: refactor pl011_startup() Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-09-24 23:11 ` Timur Tabi
2015-09-24 23:11 ` Timur Tabi
2015-09-25 15:21 ` Andre Przywara
2015-09-25 15:21 ` Andre Przywara
2015-09-25 15:30 ` Russell King - ARM Linux
2015-09-25 15:30 ` Russell King - ARM Linux
2015-05-21 16:26 ` [PATCH v5 03/11] drivers: PL011: refactor pl011_shutdown() Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 04/11] drivers: PL011: refactor pl011_set_termios() Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 05/11] drivers: PL011: refactor pl011_probe() Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-08-09 0:59 ` Timur Tabi
2015-08-09 0:59 ` Timur Tabi
2015-09-03 16:54 ` Andre Przywara
2015-09-03 16:54 ` Andre Przywara
2015-09-03 18:09 ` Timur Tabi [this message]
2015-09-03 18:09 ` Timur Tabi
2015-05-21 16:26 ` [PATCH v5 06/11] drivers: PL011: replace UART_MIS reading with _RIS & _IMSC Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 07/11] drivers: PL011: move cts_event workaround into separate function Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 08/11] drivers: PL011: allow avoiding UART enabling/disabling Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 09/11] drivers: PL011: allow to supply fixed option string Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 10/11] drivers: PL011: add support for the ARM SBSA generic UART Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 16:26 ` [PATCH v5 11/11] drivers: PL011: add ACPI probing for SBSA UART Andre Przywara
2015-05-21 16:26 ` Andre Przywara
2015-05-21 17:19 ` [PATCH v5 00/11] drivers: PL011: add ARM SBSA Generic UART support Mark Langsdorf
2015-05-21 17:19 ` Mark Langsdorf
2015-05-21 17:45 ` Graeme Gregory
2015-05-21 17:45 ` Graeme Gregory
2015-05-22 13:14 ` Naresh Bhat
2015-05-22 13:14 ` Naresh Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E88CE4.7080401@tabi.org \
--to=timur@tabi.org \
--cc=Dave.Martin@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=moorray3@wp.pl \
--cc=nareshgbhat@gmail.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.