From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Mike Marciniszyn
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/hfi1: Add CSRs for CONFIG_SDMA_VERBOSITY
Date: Thu, 3 Sep 2015 15:29:05 -0400 [thread overview]
Message-ID: <55E89F81.7000904@redhat.com> (raw)
In-Reply-To: <20150902144324.29183.67166.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2720 bytes --]
On 09/02/2015 10:43 AM, Mike Marciniszyn wrote:
> From: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> 3 CSRs needed by the CONFIG_SDMA_VERBOSITY code were removed during
> the CSR clean up. Adding these CSRs back to resolve 0-day build failure:
> https://lists.01.org/pipermail/kbuild-all/2015-August/011919.html
>
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Thanks, applied.
> ---
> drivers/staging/rdma/hfi1/chip_registers.h | 3 +++
> drivers/staging/rdma/hfi1/sdma.c | 4 ++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rdma/hfi1/chip_registers.h b/drivers/staging/rdma/hfi1/chip_registers.h
> index 6521030..bf45de2 100644
> --- a/drivers/staging/rdma/hfi1/chip_registers.h
> +++ b/drivers/staging/rdma/hfi1/chip_registers.h
> @@ -1285,5 +1285,8 @@
> #define PCIE_CFG_REG_PL106_GEN3_EQ_PSET_REQ_VEC_SHIFT 8
> #define PCIE_CFG_REG_PL106_GEN3_EQ_EVAL2MS_DISABLE_SMASK 0x20ull
> #define PCIE_CFG_REG_PL106_GEN3_EQ_PHASE23_EXIT_MODE_SMASK 0x10ull
> +#define CCE_INT_BLOCKED (CCE + 0x000000110C00)
> +#define SEND_DMA_IDLE_CNT (TXE + 0x000000200040)
> +#define SEND_DMA_DESC_FETCHED_CNT (TXE + 0x000000200058)
>
> #endif /* DEF_CHIP_REG */
> diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
> index 37bd767..a8c903c 100644
> --- a/drivers/staging/rdma/hfi1/sdma.c
> +++ b/drivers/staging/rdma/hfi1/sdma.c
> @@ -1769,7 +1769,7 @@ void sdma_dumpstate(struct sdma_engine *sde)
> sdma_dumpstate_helper(SD(ENG_ERR_MASK));
>
> for (i = 0; i < CCE_NUM_INT_CSRS; ++i) {
> - sdma_dumpstate_helper2(CCE_INT_STATUS));
> + sdma_dumpstate_helper2(CCE_INT_STATUS);
> sdma_dumpstate_helper2(CCE_INT_MASK);
> sdma_dumpstate_helper2(CCE_INT_BLOCKED);
> }
> @@ -1777,7 +1777,7 @@ void sdma_dumpstate(struct sdma_engine *sde)
> sdma_dumpstate_helper(SD(TAIL));
> sdma_dumpstate_helper(SD(HEAD));
> sdma_dumpstate_helper(SD(PRIORITY_THLD));
> - sdma_dumpstate_helper(SD(IDLE_CNT);
> + sdma_dumpstate_helper(SD(IDLE_CNT));
> sdma_dumpstate_helper(SD(RELOAD_CNT));
> sdma_dumpstate_helper(SD(DESC_CNT));
> sdma_dumpstate_helper(SD(DESC_FETCHED_CNT));
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2015-09-03 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 14:43 [PATCH] IB/hfi1: Add CSRs for CONFIG_SDMA_VERBOSITY Mike Marciniszyn
[not found] ` <20150902144324.29183.67166.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2015-09-03 19:29 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E89F81.7000904@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.