From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] IB/core: Remove unnecessary defines from ib_mad.h
Date: Thu, 3 Sep 2015 15:51:47 -0400 [thread overview]
Message-ID: <55E8A4D3.9020501@redhat.com> (raw)
In-Reply-To: <1441233955-31743-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
On 09/02/2015 06:45 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Remove the unused IB_NOTICE_REPRESS_* defines.
>
> When the hfi1 driver was added these definitions were moved from the qib driver
> to ib_mad.h. They should have been removed instead.
>
> Fixes: d4ab347005fb ("IB/core: Add core header changes needed for OPA")
> Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> include/rdma/ib_mad.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h
> index c206205bbf98..7f2cf855a0b6 100644
> --- a/include/rdma/ib_mad.h
> +++ b/include/rdma/ib_mad.h
> @@ -157,18 +157,6 @@
> #define IB_NOTICE_TRAP_BAD_QKEY cpu_to_be16(258)
>
> /*
> - * Repress trap/notice flags
> - */
> -#define IB_NOTICE_REPRESS_LLI_THRESH (1 << 0)
> -#define IB_NOTICE_REPRESS_EBO_THRESH (1 << 1)
> -#define IB_NOTICE_REPRESS_FLOW_UPDATE (1 << 2)
> -#define IB_NOTICE_REPRESS_CAP_MASK_CHG (1 << 3)
> -#define IB_NOTICE_REPRESS_SYS_GUID_CHG (1 << 4)
> -#define IB_NOTICE_REPRESS_BAD_MKEY (1 << 5)
> -#define IB_NOTICE_REPRESS_BAD_PKEY (1 << 6)
> -#define IB_NOTICE_REPRESS_BAD_QKEY (1 << 7)
> -
> -/*
> * Generic trap/notice other local changes flags (trap 144).
> */
> #define IB_NOTICE_TRAP_LSE_CHG 0x04 /* Link Speed Enable changed */
>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2015-09-03 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 22:45 [PATCH 1/2] IB/core: Remove unnecessary defines from ib_mad.h ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1441233955-31743-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-02 22:45 ` [PATCH 2/2] IB/core: Move SM class defines from ib_mad.h to ib_smi.h ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1441233955-31743-2-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-03 17:40 ` Hal Rosenstock
2015-09-03 17:40 ` [PATCH 1/2] IB/core: Remove unnecessary defines from ib_mad.h Hal Rosenstock
2015-09-03 19:51 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E8A4D3.9020501@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.