From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758166AbbIDHMc (ORCPT ); Fri, 4 Sep 2015 03:12:32 -0400 Received: from mga14.intel.com ([192.55.52.115]:19013 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751939AbbIDHMa (ORCPT ); Fri, 4 Sep 2015 03:12:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,467,1437462000"; d="scan'208";a="797594728" Subject: Re: [tip:perf/urgent] perf evlist: Open event on evsel cpus and threads To: Jiri Olsa , Arnaldo Carvalho de Melo References: <1440138194-17001-1-git-send-email-kan.liang@intel.com> <55E84C60.4010309@intel.com> <20150903152713.GA2537@redhat.com> <55E8740F.1010107@intel.com> <20150903164109.GB2537@redhat.com> <20150903181939.GA20908@krava.redhat.com> <20150903204106.GA2570@redhat.com> <20150904070507.GC24774@krava.redhat.com> Cc: kan.liang@intel.com, mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <55E943B7.6000408@intel.com> Date: Fri, 4 Sep 2015 10:09:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150904070507.GC24774@krava.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/15 10:05, Jiri Olsa wrote: > On Thu, Sep 03, 2015 at 05:41:06PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Thu, Sep 03, 2015 at 08:19:39PM +0200, Jiri Olsa escreveu: >>> On Thu, Sep 03, 2015 at 01:41:09PM -0300, Arnaldo Carvalho de Melo wrote: >>>> Em Thu, Sep 03, 2015 at 07:23:43PM +0300, Adrian Hunter escreveu: >>>>> On 3/09/2015 6:27 p.m., Arnaldo Carvalho de Melo wrote: >>>>>> Em Thu, Sep 03, 2015 at 04:34:24PM +0300, Adrian Hunter escreveu: >>>>>>> On 01/09/15 11:31, tip-bot for Kan Liang wrote: >>>>>> Something we could catch in a 'test' entry? Even if that required Intel >>>>>> PT hardware that would be something important to have, all this stuff is >>>>>> growing in complexity, we need those tests... >> >>>>> There is "Test tracking with sched_switch" but you need to expose it >>>>> to the same issue i.e. >> >>>> Sure, Kan and Jiri were talking about the need to go doing these >>>> changes, Jiri? Kan? >> >>> perf_evlist__propagate_maps is called from perf_evlist__create_maps, >>> so if evsel is added later it will not be affected, perhaps we need >>> something like below: >> >>> +++ b/tools/perf/util/evlist.c >>> @@ -133,6 +133,9 @@ void perf_evlist__add(struct perf_evlist *evlist, struct perf_evsel *entry) >>> >>> if (!evlist->nr_entries++) >>> perf_evlist__set_id_pos(evlist); >>> + >>> + entry->cpus = cpu_map__get(evlist->cpus); >>> + entry->threads = thread_map__get(evlist->threads); >> >> You can't simply do that, we need to do it only if those fields are not >> already set. > > argh, right.. forgot about cpus setup.. anyway, Adrian already wanted > to do single function for this and the propagate function yeah, I started working on it this morning.