Re: [RFC] gpio-pca953x driver and PCA9536 chip

["Janusz Użycki" <j.uzycki-cjVIcFy54eMe9JSWTWOYM+658FiBabzs@public.gmane.org>]

W dniu 2015-08-31 o 16:26, Janusz Użycki pisze:
> Hi,
>
> The driver sets register #02 (inversion) to 0x01 instead of 0x00 on my 
> board.
> Reason: device_pca953x_init() does not initialize val buffer because 
> NBANK() returns
> for PCA9536 ngpio=4 value 0 instead of 1.
>
> My proposed code-patch for 3.14.17 is below.
> Because I don't work on stable/next I can't deliver complete/ready patch.
> Please for comments.
>
> best regards
> Janusz
>
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -75,7 +75,7 @@ MODULE_DEVICE_TABLE(i2c, pca953x_id);
>  #define MAX_BANK 5
>  #define BANK_SZ 8
>
> -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
> +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ)
>
>  struct pca953x_chip {
>         unsigned gpio_start;

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html